From: Leon Romanovsky <leon@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, sgoutham@marvell.com
Subject: Re: [net-next PATCH] octeontx2-af: Removed unnecessary debug messages.
Date: Mon, 30 Jan 2023 11:55:45 +0200 [thread overview]
Message-ID: <Y9eUIfUkwf69ntJm@unreal> (raw)
In-Reply-To: <20230130035556.694814-1-rkannoth@marvell.com>
On Mon, Jan 30, 2023 at 09:25:56AM +0530, Ratheesh Kannoth wrote:
> From: Sunil Goutham <sgoutham@marvell.com>
>
> NPC exact match feature is supported only on one silicon
> variant, removed debug messages which print that this
> feature is not available on all other silicon variants.
>
> Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
> ---
> .../net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
> index f69102d20c90..ad1374a12a40 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
> @@ -200,10 +200,8 @@ void npc_config_secret_key(struct rvu *rvu, int blkaddr)
> struct rvu_hwinfo *hw = rvu->hw;
> u8 intf;
>
> - if (!hwcap->npc_hash_extract) {
> - dev_info(rvu->dev, "HW does not support secret key configuration\n");
> + if (!hwcap->npc_hash_extract)
> return;
> - }
>
> for (intf = 0; intf < hw->npc_intfs; intf++) {
> rvu_write64(rvu, blkaddr, NPC_AF_INTFX_SECRET_KEY0(intf),
> @@ -221,10 +219,8 @@ void npc_program_mkex_hash(struct rvu *rvu, int blkaddr)
> struct rvu_hwinfo *hw = rvu->hw;
> u8 intf;
>
> - if (!hwcap->npc_hash_extract) {
> - dev_dbg(rvu->dev, "Field hash extract feature is not supported\n");
> + if (!hwcap->npc_hash_extract)
> return;
> - }
>
> for (intf = 0; intf < hw->npc_intfs; intf++) {
> npc_program_mkex_hash_rx(rvu, blkaddr, intf);
> @@ -1854,16 +1850,12 @@ int rvu_npc_exact_init(struct rvu *rvu)
> /* Check exact match feature is supported */
> npc_const3 = rvu_read64(rvu, blkaddr, NPC_AF_CONST3);
> if (!(npc_const3 & BIT_ULL(62))) {
> - dev_info(rvu->dev, "%s: No support for exact match support\n",
> - __func__);
> return 0;
> }
You should remove () brackets here too.
>
> /* Check if kex profile has enabled EXACT match nibble */
> cfg = rvu_read64(rvu, blkaddr, NPC_AF_INTFX_KEX_CFG(NIX_INTF_RX));
> if (!(cfg & NPC_EXACT_NIBBLE_HIT)) {
> - dev_info(rvu->dev, "%s: NPC exact match nibble not enabled in KEX profile\n",
> - __func__);
> return 0;
> }
Same comment.
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-01-30 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 3:55 [net-next PATCH] octeontx2-af: Removed unnecessary debug messages Ratheesh Kannoth
2023-01-30 9:55 ` Leon Romanovsky [this message]
2023-01-31 7:11 ` [EXT] " Ratheesh Kannoth
2023-01-31 9:20 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9eUIfUkwf69ntJm@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).