archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <>
To: Andrew Lunn <>
Cc: Wei Fang <>, Jakub Kicinski <>,
	Arnd Bergmann <>,
	Shenwei Wang <>,
	Clark Wang <>,
	NXP Linux Team <>,
	"David S. Miller" <>,
	Eric Dumazet <>,
	Paolo Abeni <>,
	Marc Kleine-Budde <>,,
Subject: Re: [PATCH v2] net: fec: fix conversion to gpiod API
Date: Wed, 1 Feb 2023 10:25:15 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <Y9qprbyr/>

On Wed, Feb 01, 2023 at 07:04:29PM +0100, Andrew Lunn wrote:
> On Tue, Jan 31, 2023 at 07:23:16PM -0800, Dmitry Torokhov wrote:
> > The reset line is optional, so we should be using devm_gpiod_get_optional()
> > and not abort probing if it is not available. Also, there is a quirk in
> > gpiolib (introduced in b02c85c9458cdd15e2c43413d7d2541a468cde57) that
> > transparently handles "phy-reset-active-high" property. Remove handling
> > from the driver to avoid ending up with the double inversion/flipped
> > logic.
> > 
> > Fixes: 468ba54bd616 ("fec: convert to gpio descriptor")
> > Signed-off-by: Dmitry Torokhov <>
> Please split this into two:
> 1) Fix for it being optional
> 2) Removing support for phy-reset-active-high
> The breakage is in net-next, so we are not in a rush, and we don't
> need a minimum of patches. So since this is two logical changes, it
> should be two patches.

Hm, so you want the driver be still broken after changing the call to be
devm_gpiod_get_optional()? Because you can not have this driver use
gpiod API and keep parsing 'phy-reset-active-high' (by the driver

OK, I suppose I can do that...

> Please also update the binding document to indicate that
> 'phy-reset-active-high' is no longer deprecated, it has actually been
> removed. So we want the DT checking tools to error out if such a
> property is found.

We still parse 'phy-reset-active-high', just parsing happens elsewhere
(in gpiolib), so it is not an error to have it in a binding.



      reply	other threads:[~2023-02-01 18:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01  3:23 [PATCH v2] net: fec: fix conversion to gpiod API Dmitry Torokhov
2023-02-01  8:46 ` Marc Kleine-Budde
2023-02-01 18:04 ` Andrew Lunn
2023-02-01 18:25   ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).