From: Stephan Gerhold <stephan@gerhold.net>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: Jonathan Albrieux <jonathan.albrieux@gmail.com>,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: qcom: Add device tree for BQ Aquaris X5 (Longcheer L8910)
Date: Sun, 24 Jan 2021 16:45:35 +0100 [thread overview]
Message-ID: <YA2WHwuKwaLZ9sVm@gerhold.net> (raw)
In-Reply-To: <cb299b22-f00f-c8fd-648e-6f34c34b0967@somainline.org>
On Sun, Jan 24, 2021 at 04:12:30PM +0100, Konrad Dybcio wrote:
> The sorting on smd_rpm_regulators & msmgpio seems off.. unless it's the new thing to put it at the end?
>
It's consistent like this for all MSM8916 device trees at least.
Back when I converted them I thought that it's kind of annoying to have
this large list of regulators and pinctrl placed right inbetween all
other device definitions. And it's even worse for apq8016-sbc.dtsi which
has this large list of gpio-line-names. It just makes it harder to see
the actual interesting definitions (new devices etc) in my opinion.
I think I mentioned this in my patch description back then
and Bjorn did not complain. :-)
But I understand this may be somewhat inconsistent with other qcom
device trees at the moment, so I suppose I would be fine with a patch
to order them entirely alphabetically.
(As long as it's consistent for all MSM8916 device trees...)
Thanks,
Stephan
next prev parent reply other threads:[~2021-01-24 15:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-24 13:54 [PATCH 0/3] Add initial support for BQ Aquaris X5 Jonathan Albrieux
2021-01-24 13:54 ` [PATCH 1/3] arm64: dts: qcom: Add device tree for BQ Aquaris X5 (Longcheer L8910) Jonathan Albrieux
2021-01-24 15:12 ` Konrad Dybcio
2021-01-24 15:45 ` Stephan Gerhold [this message]
2021-01-24 13:54 ` [PATCH 2/3] arm64: dts: qcom: msm8916: Add blsp_i2c3 Jonathan Albrieux
2021-01-24 15:09 ` Konrad Dybcio
2021-01-24 15:52 ` Stephan Gerhold
2021-01-24 13:54 ` [PATCH 3/3] arm64: dts: qcom: msm8916-longcheer-l8910: Add imu/magnetometer Jonathan Albrieux
2021-01-24 15:07 ` Konrad Dybcio
2021-01-24 15:51 ` Stephan Gerhold
2021-01-24 19:49 ` Jonathan Albrieux
2021-01-28 4:22 ` Bjorn Andersson
2021-01-24 21:01 ` [PATCH 0/3] Add initial support for BQ Aquaris X5 Pavel Machek
2021-01-24 21:49 ` Stephan Gerhold
2021-01-27 22:24 ` Pavel Machek
2021-01-28 9:27 ` Stephan Gerhold
2021-02-02 13:13 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YA2WHwuKwaLZ9sVm@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathan.albrieux@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).