From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
agross@kernel.org, mchehab@kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
konrad.dybcio@somainline.org, marijn.suijten@somainline.org,
phone-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] media: venus: core: Add sdm660 DT compatible and resource struct
Date: Mon, 25 Jan 2021 09:18:45 -0600 [thread overview]
Message-ID: <YA7hVQVTXT554cKN@builder.lan> (raw)
In-Reply-To: <40c38734-a69d-2314-c342-244ee5a0e6b1@somainline.org>
On Mon 25 Jan 08:51 CST 2021, AngeloGioacchino Del Regno wrote:
> Il 25/01/21 11:40, Hans Verkuil ha scritto:
> > On 18/01/2021 18:45, AngeloGioacchino Del Regno wrote:
> > > Il 18/01/21 18:21, Stanimir Varbanov ha scritto:
> > > > > diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
[..]
> > > > > + .fwname = "qcom/venus-4.4/venus.mdt",
[..]
> > This patch can't be merged unless there is a corresponding firmware available
> > in linux-firmware. Is the current 4.2 firmware in linux-firmware signed by
> > Qualcomm? Can they provided 4.4 firmware as well?
> >
>
> If there is such issue, then maybe we should do "something" about it: I
> would then propose to remove all references to fwname and just get this
> done in DT, where every qcom board already specifies its own path for
> its own firmware.
>
We have the same problem with production devices on e.g. SDM845, where
the firmware referenced by fw_name and present in linux-firmware won't
work on any real devices.
As such, providing means for specifying the firmware name in DT would be
a very reasonable thing, and in line with how we handle this in other
subsystems (using the firmware-name property, containing the full
relative path).
Regards,
Bjorn
next prev parent reply other threads:[~2021-01-26 7:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 18:52 [PATCH 0/2] SDM630/660 Venus hardware video decoder/encoder AngeloGioacchino Del Regno
2021-01-15 18:52 ` [PATCH 1/2] media: venus: core: Add sdm660 DT compatible and resource struct AngeloGioacchino Del Regno
2021-01-18 17:21 ` Stanimir Varbanov
2021-01-18 17:45 ` AngeloGioacchino Del Regno
2021-01-25 10:40 ` Hans Verkuil
2021-01-25 14:51 ` AngeloGioacchino Del Regno
2021-01-25 15:01 ` Hans Verkuil
2021-01-26 8:44 ` Stanimir Varbanov
2021-01-25 15:18 ` Bjorn Andersson [this message]
2021-01-15 18:52 ` [PATCH 2/2] media: dt-bindings: media: venus: Add sdm660 DT schema AngeloGioacchino Del Regno
2021-01-17 15:45 ` Rob Herring
2021-01-17 19:23 ` AngeloGioacchino Del Regno
2021-01-18 17:21 ` Stanimir Varbanov
2021-01-18 17:48 ` AngeloGioacchino Del Regno
2021-01-19 23:17 ` Rob Herring
2021-01-19 23:19 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YA7hVQVTXT554cKN@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).