From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B39ACC433E0 for ; Sat, 16 Jan 2021 00:04:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D1A323A5E for ; Sat, 16 Jan 2021 00:04:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728819AbhAPADj (ORCPT ); Fri, 15 Jan 2021 19:03:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726650AbhAPADi (ORCPT ); Fri, 15 Jan 2021 19:03:38 -0500 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27376C061793 for ; Fri, 15 Jan 2021 16:02:58 -0800 (PST) Received: by mail-pg1-x52a.google.com with SMTP id p18so7007175pgm.11 for ; Fri, 15 Jan 2021 16:02:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WFx/F2a337GN3zwqNOD7iXQOOHYeEmZ62a3KeLo+VSA=; b=FAl4ne1TgJ+b6aXfP13BMx6boigr8gF546SOdYwutRbfGMrVLhW5/YQjeSCWv9MnJK fjFVkqfMPw5o20cOsu/oHvxPktKjsd2hCc5ZJDnT4CU74ljPGK9iapSbE39IM4+oTtZu jOXOPR9Y4ji6K0HpHLeXAAkA2XA1e9IbLr0+pXxq8NJt4mk80e3WpXtsnpODU+ickgi/ F75TATcI3RC/TvTZKJD1polGq28uoA2F/c8kxHWW1OKWwWztzfvZjLadeWFKbCQ6w+kr eL2dc8CPW+8iU1nxypJStahsZHCbLeJjtmtcyvhtCbv8MhVpK2uWkC+HNfHsch/Qr0L5 aRSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WFx/F2a337GN3zwqNOD7iXQOOHYeEmZ62a3KeLo+VSA=; b=UateLKcrbaX28LvWSajwbyITrJKLVVGHcmFOjec5bzPLQlZYTcCrfZljAuCAcmfv+q MBRP4irOxOkwHwT229yLgYuW+h3K5L/X1Ai2QCXnwNFKR2oVoiWxZTac5NuI6YmOKuN8 EBYTNltjosMXGj18v8XPRjKN63vsPlL20UI4jQ33+nMQPfLiLf67hgkAEz7MllxDhhyS tqrSeYHKg+Qm9Bo6UTXqsQLaawyRCLTBkUGzVRCy58F5dqK2Q9gsu/IUV6a3DXZGqoCn WHMR0FfXm4CbS7LrYq+w+SRP0Zsz8eNBuav6F5VkJVPfGmlF3vBD7bbQfY5YLPne7WIr x1+Q== X-Gm-Message-State: AOAM532Am/y7yqDG73CfA9JsurBiv+tKpgTThubRCKlDzm573MG1trW9 nV3r8u5XSW8o+CmoIitBWYdUqA== X-Google-Smtp-Source: ABdhPJz5JLyoykloTcJIV6mJIvCkLo2bUWGXy25NqJDkE7lNF5Uy2EU7DNr/+lXYQrUVAjngZjTEzw== X-Received: by 2002:a62:cd49:0:b029:1b5:4e48:6f1a with SMTP id o70-20020a62cd490000b02901b54e486f1amr1640904pfg.14.1610755377518; Fri, 15 Jan 2021 16:02:57 -0800 (PST) Received: from google.com ([2620:15c:f:10:1ea0:b8ff:fe73:50f5]) by smtp.gmail.com with ESMTPSA id 19sm8981531pfu.85.2021.01.15.16.02.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 16:02:56 -0800 (PST) Date: Fri, 15 Jan 2021 16:02:50 -0800 From: Sean Christopherson To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Peter Xu , Andrew Jones , Peter Shier , Sean Christopherson , Thomas Huth , Jacob Xu , Makarand Sonare Subject: Re: [PATCH 4/6] KVM: selftests: Fix population stage in dirty_log_perf_test Message-ID: References: <20210112214253.463999-1-bgardon@google.com> <20210112214253.463999-5-bgardon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210112214253.463999-5-bgardon@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 12, 2021, Ben Gardon wrote: > Currently the population stage in the dirty_log_perf_test does nothing > as the per-vCPU iteration counters are not initialized and the loop does > not wait for each vCPU. Remedy those errors. > > Reviewed-by: Jacob Xu > Reviewed-by: Makarand Sonare > > Signed-off-by: Ben Gardon > --- > tools/testing/selftests/kvm/dirty_log_perf_test.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/kvm/dirty_log_perf_test.c b/tools/testing/selftests/kvm/dirty_log_perf_test.c > index 3875f22d7283..fb6eb7fa0b45 100644 > --- a/tools/testing/selftests/kvm/dirty_log_perf_test.c > +++ b/tools/testing/selftests/kvm/dirty_log_perf_test.c > @@ -139,14 +139,19 @@ static void run_test(enum vm_guest_mode mode, void *arg) > > clock_gettime(CLOCK_MONOTONIC, &start); > for (vcpu_id = 0; vcpu_id < nr_vcpus; vcpu_id++) { > + vcpu_last_completed_iteration[vcpu_id] = -1; > + > pthread_create(&vcpu_threads[vcpu_id], NULL, vcpu_worker, > &perf_test_args.vcpu_args[vcpu_id]); > } > > - /* Allow the vCPU to populate memory */ > + /* Allow the vCPUs to populate memory */ > pr_debug("Starting iteration %d - Populating\n", iteration); > - while (READ_ONCE(vcpu_last_completed_iteration[vcpu_id]) != iteration) > - ; > + for (vcpu_id = 0; vcpu_id < nr_vcpus; vcpu_id++) { > + while (READ_ONCE(vcpu_last_completed_iteration[vcpu_id]) != > + iteration) Same comment as earlier. I vote to let this poke out, or shorten the variables so that the lines aren't so long. > + ; > + } > > ts_diff = timespec_elapsed(start); > pr_info("Populate memory time: %ld.%.9lds\n", > -- > 2.30.0.284.gd98b1dd5eaa7-goog >