From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: kernel test robot <lkp@intel.com>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-kernel@vger.kernel.org, kbuild-all@lists.01.org,
clang-built-linux@googlegroups.com,
"Lee Jones" <lee.jones@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>
Subject: Re: [PATCH v8 3/7] mfd: Add base driver for Netronix embedded controller
Date: Mon, 18 Jan 2021 01:43:38 +0100 [thread overview]
Message-ID: <YATZuivr8CzHI5X2@latitude> (raw)
In-Reply-To: <202101170941.YsXQPP40-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
On Sun, Jan 17, 2021 at 09:22:01AM +0800, kernel test robot wrote:
[...]
> >> drivers/mfd/ntxec.c:127:10: warning: variable 'res' is uninitialized when used here [-Wuninitialized]
> return res;
> ^~~
> drivers/mfd/ntxec.c:116:9: note: initialize the variable 'res' to silence this warning
> int res;
> ^
> = 0
> 1 warning generated.
[...]
> 124 ec->regmap = devm_regmap_init_i2c(client, ®map_config);
> 125 if (IS_ERR(ec->regmap)) {
> 126 dev_err(ec->dev, "Failed to set up regmap for device\n");
> > 127 return res;
> 128 }
Ah well, that's a bug (present since v2 of the patchset). The return
statement should be:
return PTR_ERR(ec->regmap);
Thanks,
Jonathan Neuschäfer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-18 0:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 19:48 [PATCH v8 0/7] Netronix embedded controller driver for Kobo and Tolino ebook readers Jonathan Neuschäfer
2021-01-16 19:48 ` [PATCH v8 1/7] dt-bindings: Add vendor prefix for Netronix, Inc Jonathan Neuschäfer
2021-01-16 19:48 ` [PATCH v8 2/7] dt-bindings: mfd: Add binding for Netronix embedded controller Jonathan Neuschäfer
2021-01-16 19:48 ` [PATCH v8 3/7] mfd: Add base driver " Jonathan Neuschäfer
2021-01-17 1:22 ` kernel test robot
2021-01-18 0:43 ` Jonathan Neuschäfer [this message]
2021-01-16 19:48 ` [PATCH v8 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC Jonathan Neuschäfer
2021-01-20 17:37 ` Thierry Reding
2021-01-16 19:48 ` [PATCH v8 5/7] rtc: New driver for RTC in Netronix embedded controller Jonathan Neuschäfer
2021-01-16 19:48 ` [PATCH v8 6/7] MAINTAINERS: Add entry for " Jonathan Neuschäfer
2021-01-16 19:48 ` [PATCH v8 7/7] ARM: dts: imx50-kobo-aura: Add " Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YATZuivr8CzHI5X2@latitude \
--to=j.neuschaefer@gmx.net \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=clang-built-linux@googlegroups.com \
--cc=kbuild-all@lists.01.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).