From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_RED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3429C433DB for ; Tue, 19 Jan 2021 08:29:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96DF22312D for ; Tue, 19 Jan 2021 08:29:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731490AbhASI3D (ORCPT ); Tue, 19 Jan 2021 03:29:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:50560 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730691AbhASI1k (ORCPT ); Tue, 19 Jan 2021 03:27:40 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id ED87C2311C; Tue, 19 Jan 2021 08:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611044819; bh=+Q+XPSElQgpBDAKZynrp8adUrT0O6HKRNCJn++9NB2E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y3y+bNhPsgZySuRFBVeWqJZKvWn7F9xTrD/4sJXpl8dxZFSJUZ0ch67wuwoBBm3ue uaJGFQLRyhPSxkTVB11yGqn86IIQbdEAnwJgIIaZsQsk0LqS1THH3trbHLCRiIqs8E 7Eu//fwIItYRjJOFE7hxzh0DAEOFjMPhL7FXa5uo= Date: Tue, 19 Jan 2021 09:26:55 +0100 From: Greg Kroah-Hartman To: Kai-Heng Feng Cc: rjw@rjwysocki.net, AceLan Kao , "Rafael J. Wysocki" , Mika Westerberg , Andy Shevchenko , Len Brown , "open list:ACPI" , open list Subject: Re: [PATCH] ACPI / device_sysfs: Use OF_MODALIAS for "compatible" modalias Message-ID: References: <20210119081513.300938-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210119081513.300938-1-kai.heng.feng@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2021 at 04:15:13PM +0800, Kai-Heng Feng wrote: > Commit 8765c5ba1949 ("ACPI / scan: Rework modalias creation when > "compatible" is present") may create two "MODALIAS=" in uevent file if > conditions are met. > > This breaks systemd-udevd, which assumes each "key" in uevent file is > unique. The internal implementation of systemd-udevd overwrites the > first MODALIAS with the second one, so its kmod rule doesn't load driver > for the first MODALIAS. > > Right now it doesn't seem to have any user relies on the second > MODALIAS, so change it to OF_MODALIAS to workaround the issue. > > Reference: https://github.com/systemd/systemd/pull/18163 > Fixes: 8765c5ba1949 ("ACPI / scan: Rework modalias creation when "compatible" is present") > Cc: AceLan Kao > Cc: "Rafael J. Wysocki" > Cc: Greg Kroah-Hartman , > Cc: Mika Westerberg , > Cc: Andy Shevchenko > Signed-off-by: Kai-Heng Feng > --- > drivers/acpi/device_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c > index 96869f1538b9..c92b671cb816 100644 > --- a/drivers/acpi/device_sysfs.c > +++ b/drivers/acpi/device_sysfs.c > @@ -260,7 +260,7 @@ int __acpi_device_uevent_modalias(struct acpi_device *adev, > if (!adev->data.of_compatible) > return 0; > > - if (len > 0 && add_uevent_var(env, "MODALIAS=")) > + if (len > 0 && add_uevent_var(env, "OF_MODALIAS=")) Who will use OF_MODALIAS and where have you documented it? thanks, greg k-h