From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 037E8C43219 for ; Wed, 20 Jan 2021 14:14:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACA3623383 for ; Wed, 20 Jan 2021 14:14:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390391AbhATONR (ORCPT ); Wed, 20 Jan 2021 09:13:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388241AbhATNLj (ORCPT ); Wed, 20 Jan 2021 08:11:39 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63040C0613CF for ; Wed, 20 Jan 2021 05:11:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cWnQ4I32TIvpJOw8Q92cr9oKfPVoryLnq4TaPojC+IM=; b=wR1VoXSZvxClmwzOl5f02QBtBJ 3c3l3FZ2PlENBI/LcsQlX64AxcZRFAUp41Xanw/Cgh8xvONaV1T93iv/jyKyMHP4gaYM7WcMAhcqw gd6hboyr/FhTYFmWmvVElN/qKACdNDK9A55xRk0lF589kvxJPVasfc3kz4G0HZsPHN3SzRCiU1dyV DQc/cgNx5iLZgbrZXP6iLEF+I/e+FEc4vt7NDhUH+DzkB8KSURoWNgXviYIth5iFoShzXLbUhVuKY fYu/IKgBGMO8xasoO+8yqSKkCc4G4yBXoILya73pHWMs9N9mt5irz6rm2z/NAzFUf5WrSyrFLDRM8 J4+qKiag==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2DGX-00071n-79; Wed, 20 Jan 2021 13:11:17 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 47804301959; Wed, 20 Jan 2021 14:11:14 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 07C05200E3598; Wed, 20 Jan 2021 14:11:14 +0100 (CET) Date: Wed, 20 Jan 2021 14:11:13 +0100 From: Peter Zijlstra To: vincent.donnefort@arm.com Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, valentin.schneider@arm.com Subject: Re: [PATCH 3/4] cpu/hotplug: Add cpuhp_invoke_callback_range() Message-ID: References: <1610385047-92151-1-git-send-email-vincent.donnefort@arm.com> <1610385047-92151-4-git-send-email-vincent.donnefort@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1610385047-92151-4-git-send-email-vincent.donnefort@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 05:10:46PM +0000, vincent.donnefort@arm.com wrote: > @@ -157,26 +162,24 @@ static int cpuhp_invoke_callback(unsigned int cpu, enum cpuhp_state state, > > if (st->fail == state) { > st->fail = CPUHP_INVALID; > - > - if (!(bringup ? step->startup.single : step->teardown.single)) > - return 0; > - > return -EAGAIN; > } > > + if (cpuhp_step_empty(bringup, step)) { > + WARN_ON_ONCE(1); > + return 0; > + } This changes the behaviour of fail.. might be best to refactor without changing behaviour. Lemme continue reading.