From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFF5EC433E0 for ; Wed, 20 Jan 2021 18:02:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B57C2223E0 for ; Wed, 20 Jan 2021 18:02:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731788AbhATSBy (ORCPT ); Wed, 20 Jan 2021 13:01:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:43042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390516AbhATSAc (ORCPT ); Wed, 20 Jan 2021 13:00:32 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9DFFD223DB; Wed, 20 Jan 2021 17:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611165576; bh=s0dN1TK33kbfDqHmKurIDYw4217DCfn5gFKZLOzRfU8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ziQt/0GX6BOYqiMcw5gpnlqIQ89SoM+F114/feT/OPUQ2albCFRDVmli5GR0nXBRw CC8ACWzI1I39iNciaYpyDpKw7R8cKoKJ6V+K1o1sfbTywBSFktvZTix0XwTfS0WehR EFLR06t9bCTKR1QbC/tRMFO6tOvFzBE3vtUr0JCM= Date: Wed, 20 Jan 2021 18:59:33 +0100 From: Greg KH To: mgross@linux.intel.com Cc: markgross@kernel.org, arnd@arndb.de, bp@suse.de, damien.lemoal@wdc.com, dragan.cvetic@xilinx.com, corbet@lwn.net, leonard.crestez@nxp.com, palmerdabbelt@google.com, paul.walmsley@sifive.com, peng.fan@nxp.com, robh+dt@kernel.org, shawnguo@kernel.org, jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org, Srikanth Thokala Subject: Re: [PATCH v2 15/34] misc: xlink-pcie: Add XLink API interface Message-ID: References: <20210108212600.36850-1-mgross@linux.intel.com> <20210108212600.36850-16-mgross@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210108212600.36850-16-mgross@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 08, 2021 at 01:25:41PM -0800, mgross@linux.intel.com wrote: > From: Srikanth Thokala > > Provide interface for XLink layer to interact with XLink PCIe transport > layer on both local host and remote host. > > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Reviewed-by: Mark Gross > Signed-off-by: Srikanth Thokala > --- > drivers/misc/xlink-pcie/common/interface.c | 109 +++++++++++++++++++ > drivers/misc/xlink-pcie/local_host/Makefile | 1 + > drivers/misc/xlink-pcie/remote_host/Makefile | 1 + > 3 files changed, 111 insertions(+) > create mode 100644 drivers/misc/xlink-pcie/common/interface.c > > diff --git a/drivers/misc/xlink-pcie/common/interface.c b/drivers/misc/xlink-pcie/common/interface.c > new file mode 100644 > index 000000000000..56c1d9ed9d8f > --- /dev/null > +++ b/drivers/misc/xlink-pcie/common/interface.c > @@ -0,0 +1,109 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/***************************************************************************** > + * > + * Intel Keem Bay XLink PCIe Driver > + * > + * Copyright (C) 2020 Intel Corporation > + * > + ****************************************************************************/ Do you really need the ******* mess? :) > + > +#include > + > +#include "core.h" > +#include "xpcie.h" > + > +/* Define xpcie driver interface API */ > +int xlink_pcie_get_device_list(u32 *sw_device_id_list, u32 *num_devices) > +{ > + if (!sw_device_id_list || !num_devices) > + return -EINVAL; > + > + *num_devices = intel_xpcie_get_device_num(sw_device_id_list); > + > + return 0; > +} > +EXPORT_SYMBOL(xlink_pcie_get_device_list); EXPORT_SYMBOL_GPL() for all of these perhaps? I have to ask... thanks, greg k-h