From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Jari Ruusu <jariruusu@protonmail.com>,
Sasha Levin <sashal@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
masahiroy@kernel.org
Subject: Re: Kernel version numbers after 4.9.255 and 4.4.255
Date: Sat, 6 Feb 2021 08:23:06 +0100 [thread overview]
Message-ID: <YB5D2iX5s53Q8MB6@kroah.com> (raw)
In-Reply-To: <20210205184412.GA20410@duo.ucw.cz>
On Fri, Feb 05, 2021 at 07:44:12PM +0100, Pavel Machek wrote:
> Hi!
>
> > > > Ugh, I thought this was an internal representation, not an external one
> > > > :(
> > > >
> > > > > It might work somewhere, but there are a lot of (X * 65536 + Y * 256 + Z)
> > > > > assumptions all around the world. So this doesn't look like a good idea.
> > > >
> > > > Ok, so what happens if we "wrap"? What will break with that? At first
> > > > glance, I can't see anything as we keep the padding the same, and our
> > > > build scripts seem to pick the number up from the Makefile and treat it
> > > > like a string.
> > > >
> > > > It's only the crazy out-of-tree kernel stuff that wants to do minor
> > > > version checks that might go boom. And frankly, I'm not all that
> > > > concerned if they have problems :)
> > > >
> > > > So, let's leave it alone and just see what happens!
> > >
> > > Yeah, stable is a great place to do the experiments. Not that this is
> > > the first time :-(.
> >
> > How else can we "test this out"?
> >
> > Should I do an "empty" release of 4.4.256 and see if anyone complains?
>
> It seems that would be bad idea, as it would cause problems when stuff
> is compiled on 4.4.256, not simply by running it.
>
> Sasha's patch seems like one option that could work.
>
> Even safer option is to switch to 4.4.255-st1, 4.4.255-st2 ... scheme.
Using EXTRAVERSION would work, but it is effectivly the same thing as
nothing exports that to userspace through the LINUX_VERSION macro.
So clamping the version like Sasha's patches seems to be the best
solution.
thanks,
greg k-h
prev parent reply other threads:[~2021-02-06 7:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 5:59 Kernel version numbers after 4.9.255 and 4.4.255 Jari Ruusu
2021-02-04 6:20 ` Greg Kroah-Hartman
2021-02-04 7:26 ` Jiri Slaby
2021-02-04 8:51 ` Greg Kroah-Hartman
2021-02-04 11:00 ` Jiri Slaby
2021-02-04 16:28 ` David Laight
2021-02-04 16:48 ` Greg Kroah-Hartman
2021-02-04 20:19 ` Christoph Biedl
2021-02-05 6:52 ` Greg KH
2021-02-05 17:31 ` Tony Battersby
2021-02-05 18:11 ` Mauro Carvalho Chehab
2021-02-06 7:20 ` Greg Kroah-Hartman
2021-02-06 9:24 ` Mauro Carvalho Chehab
2021-02-06 9:29 ` Greg Kroah-Hartman
2021-02-06 9:48 ` Mauro Carvalho Chehab
2021-02-06 10:18 ` Hans Verkuil
2021-02-06 11:18 ` Mauro Carvalho Chehab
2021-02-06 7:22 ` Greg Kroah-Hartman
2021-02-05 9:06 ` Pavel Machek
2021-02-05 9:33 ` Greg Kroah-Hartman
2021-02-05 18:44 ` Pavel Machek
2021-02-06 7:23 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YB5D2iX5s53Q8MB6@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jariruusu@protonmail.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=pavel@ucw.cz \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).