linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Zou Wei <zou_wei@huawei.com>
Cc: andreyknvl@google.com, dvyukov@google.com, allen.lkml@gmail.com,
	stern@rowland.harvard.edu, sashal@kernel.org,
	gustavoars@kernel.org, a.darwish@linutronix.de,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] usb: core: Remove unused including <linux/version.h>
Date: Tue, 26 Jan 2021 18:39:26 +0100	[thread overview]
Message-ID: <YBBTzkPiyMZov9J0@kroah.com> (raw)
In-Reply-To: <1611578688-43256-1-git-send-email-zou_wei@huawei.com>

On Mon, Jan 25, 2021 at 08:44:48PM +0800, Zou Wei wrote:
> Fix the following versioncheck warning:
> 
> drivers/usb/core/hcd.c:14:1: unused including <linux/version.h>
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/usb/core/hcd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> index 3f03813..53bc93d 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -11,7 +11,6 @@
>  
>  #include <linux/bcd.h>
>  #include <linux/module.h>
> -#include <linux/version.h>
>  #include <linux/kernel.h>
>  #include <linux/sched/task_stack.h>
>  #include <linux/slab.h>

You didn't test this patch, why???

{sigh}

greg k-h

  reply	other threads:[~2021-01-27  0:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 12:44 [PATCH -next] usb: core: Remove unused including <linux/version.h> Zou Wei
2021-01-26 17:39 ` Greg KH [this message]
2021-09-29 16:39 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBBTzkPiyMZov9J0@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=a.darwish@linutronix.de \
    --cc=allen.lkml@gmail.com \
    --cc=andreyknvl@google.com \
    --cc=dvyukov@google.com \
    --cc=gustavoars@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashal@kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=zou_wei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).