From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Paul Gortmaker <paul.gortmaker@windriver.com> Cc: linux-kernel@vger.kernel.org, lizefan@huawei.com, mingo@kernel.org, tglx@linutronix.de, josh@joshtriplett.org, yury.norov@gmail.com, peterz@infradead.org, paulmck@kernel.org, fweisbec@gmail.com, linux@rasmusvillemoes.dk Subject: Re: [PATCH 4/8] lib: bitmap: move ERANGE check from set_region to check_region Date: Tue, 26 Jan 2021 23:19:44 +0200 [thread overview] Message-ID: <YBCHcMcwMPQLBlAV@smile.fi.intel.com> (raw) In-Reply-To: <20210126171141.122639-5-paul.gortmaker@windriver.com> On Tue, Jan 26, 2021 at 12:11:37PM -0500, Paul Gortmaker wrote: > It makes sense to do all the checks in check_region() and not 1/2 > in check_region and 1/2 in set_region. > > Since set_region is called immediately after check_region, the net > effect on runtime is zero, but it gets rid of an if (...) return... Like it! Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Yury Norov <yury.norov@gmail.com> > Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > --- > lib/bitmap.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/lib/bitmap.c b/lib/bitmap.c > index 162e2850c622..833f152a2c43 100644 > --- a/lib/bitmap.c > +++ b/lib/bitmap.c > @@ -500,17 +500,12 @@ struct region { > unsigned int nbits; > }; > > -static int bitmap_set_region(const struct region *r, unsigned long *bitmap) > +static void bitmap_set_region(const struct region *r, unsigned long *bitmap) > { > unsigned int start; > > - if (r->end >= r->nbits) > - return -ERANGE; > - > for (start = r->start; start <= r->end; start += r->group_len) > bitmap_set(bitmap, start, min(r->end - start + 1, r->off)); > - > - return 0; > } > > static int bitmap_check_region(const struct region *r) > @@ -518,6 +513,9 @@ static int bitmap_check_region(const struct region *r) > if (r->start > r->end || r->group_len == 0 || r->off > r->group_len) > return -EINVAL; > > + if (r->end >= r->nbits) > + return -ERANGE; > + > return 0; > } > > @@ -656,9 +654,7 @@ int bitmap_parselist(const char *buf, unsigned long *maskp, int nmaskbits) > if (ret) > return ret; > > - ret = bitmap_set_region(&r, maskp); > - if (ret) > - return ret; > + bitmap_set_region(&r, maskp); > } > > return 0; > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko
next prev parent reply other threads:[~2021-01-27 5:41 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-26 17:11 [PATCH v3 0/8] support for bitmap (and hence CPU) list "N" abbreviation Paul Gortmaker 2021-01-26 17:11 ` [PATCH 1/8] lib: test_bitmap: clearly separate ERANGE from EINVAL tests Paul Gortmaker 2021-01-26 21:04 ` Andy Shevchenko 2021-01-27 7:21 ` Paul Gortmaker 2021-01-26 17:11 ` [PATCH 2/8] lib: test_bitmap: add more start-end:offset/len tests Paul Gortmaker 2021-01-26 21:11 ` Andy Shevchenko 2021-01-27 3:03 ` Yury Norov 2021-01-26 17:11 ` [PATCH 3/8] lib: bitmap: fold nbits into region struct Paul Gortmaker 2021-01-26 21:16 ` Andy Shevchenko 2021-01-26 21:18 ` Andy Shevchenko 2021-01-27 8:02 ` Paul Gortmaker 2021-01-28 0:47 ` Yury Norov 2021-01-28 10:17 ` Andy Shevchenko 2021-01-27 3:08 ` Yury Norov 2021-01-26 17:11 ` [PATCH 4/8] lib: bitmap: move ERANGE check from set_region to check_region Paul Gortmaker 2021-01-26 21:19 ` Andy Shevchenko [this message] 2021-01-27 3:12 ` Yury Norov 2021-01-26 17:11 ` [PATCH 5/8] lib: bitmap_getnum: separate arg into region and field Paul Gortmaker 2021-01-26 21:23 ` Andy Shevchenko 2021-01-27 2:58 ` Yury Norov 2021-01-27 8:38 ` Paul Gortmaker 2021-01-26 17:11 ` [PATCH 6/8] lib: bitmap: support "N" as an alias for size of bitmap Paul Gortmaker 2021-01-26 21:37 ` Andy Shevchenko 2021-01-26 21:41 ` Andy Shevchenko 2021-01-27 17:57 ` Yury Norov 2021-01-27 8:20 ` Paul Gortmaker 2021-01-26 17:11 ` [PATCH 7/8] lib: test_bitmap: add tests for "N" alias Paul Gortmaker 2021-01-26 17:11 ` [PATCH 8/8] rcu: deprecate "all" option to rcu_nocbs= Paul Gortmaker 2021-01-26 21:36 ` Yury Norov 2021-01-26 22:17 ` Paul E. McKenney 2021-01-26 22:27 ` [PATCH v3 0/8] support for bitmap (and hence CPU) list "N" abbreviation Yury Norov 2021-01-27 9:12 ` Paul Gortmaker 2021-02-09 22:58 [PATCH v4 " Paul Gortmaker 2021-02-09 22:59 ` [PATCH 4/8] lib: bitmap: move ERANGE check from set_region to check_region Paul Gortmaker 2021-02-10 16:28 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YBCHcMcwMPQLBlAV@smile.fi.intel.com \ --to=andriy.shevchenko@linux.intel.com \ --cc=fweisbec@gmail.com \ --cc=josh@joshtriplett.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@rasmusvillemoes.dk \ --cc=lizefan@huawei.com \ --cc=mingo@kernel.org \ --cc=paul.gortmaker@windriver.com \ --cc=paulmck@kernel.org \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=yury.norov@gmail.com \ --subject='Re: [PATCH 4/8] lib: bitmap: move ERANGE check from set_region to check_region' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).