From: Johan Hovold <johan@kernel.org>
To: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 05/12] usb: misc: ezusb: update to use usb_control_msg_send()
Date: Wed, 27 Jan 2021 15:52:16 +0100 [thread overview]
Message-ID: <YBF+IFTNn4KMMVAw@hovoldconsulting.com> (raw)
In-Reply-To: <20210126183403.911653-6-anant.thazhemadam@gmail.com>
On Wed, Jan 27, 2021 at 12:03:56AM +0530, Anant Thazhemadam wrote:
> The newer usb_control_msg_{send|recv}() API are an improvement on the
> existing usb_control_msg() as it ensures that a short read/write is treated
> as an error, data can be used off the stack, and raw usb pipes need not be
> created in the calling functions.
> For this reason, the instance of usb_control_msg() has been replaced with
> usb_control_msg_send() appropriately.
>
> Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
> ---
> drivers/usb/misc/ezusb.c | 16 ++--------------
> 1 file changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/usb/misc/ezusb.c b/drivers/usb/misc/ezusb.c
> index f058d8029761..78aaee56c2b7 100644
> --- a/drivers/usb/misc/ezusb.c
> +++ b/drivers/usb/misc/ezusb.c
> @@ -31,24 +31,12 @@ static const struct ezusb_fx_type ezusb_fx1 = {
> static int ezusb_writememory(struct usb_device *dev, int address,
> unsigned char *data, int length, __u8 request)
> {
> - int result;
> - unsigned char *transfer_buffer;
> -
> if (!dev)
> return -ENODEV;
>
> - transfer_buffer = kmemdup(data, length, GFP_KERNEL);
> - if (!transfer_buffer) {
> - dev_err(&dev->dev, "%s - kmalloc(%d) failed.\n",
> - __func__, length);
> - return -ENOMEM;
> - }
> - result = usb_control_msg(dev, usb_sndctrlpipe(dev, 0), request,
> + return usb_control_msg_send(dev, 0, request,
> USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
> - address, 0, transfer_buffer, length, 3000);
> -
> - kfree(transfer_buffer);
> - return result;
> + address, 0, data, length, 3000, GFP_KERNEL);
> }
>
> static int ezusb_set_reset(struct usb_device *dev, unsigned short cpucs_reg,
This is a prime example of how the new helpers should be used.
With the short-write bit dropped from the commit message:
Reviewed-by: Johan Hovold <johan@kernel.org>
Johan
next prev parent reply other threads:[~2021-01-27 14:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 18:33 [PATCH v3 00/12] drivers: usb: misc: update to use usb_control_msg_{send|recv}() API Anant Thazhemadam
2021-01-26 18:33 ` [PATCH v3 01/12] usb: misc: appledisplay: update to use the " Anant Thazhemadam
2021-01-27 13:58 ` Johan Hovold
2021-01-27 14:42 ` Anant Thazhemadam
2021-01-27 17:20 ` Johan Hovold
2021-01-26 18:33 ` [PATCH v3 02/12] usb: misc: cypress_cy7c63: update to use usb_control_msg_recv() Anant Thazhemadam
2021-01-27 14:09 ` Johan Hovold
2021-01-27 14:40 ` Anant Thazhemadam
2021-01-26 18:33 ` [PATCH v3 03/12] usb: misc: cytherm: " Anant Thazhemadam
2021-01-27 14:21 ` Johan Hovold
2021-01-26 18:33 ` [PATCH v3 04/12] usb: misc: ehset: update to use the usb_control_msg_{send|recv}() API Anant Thazhemadam
2021-01-27 14:49 ` Johan Hovold
2021-01-26 18:33 ` [PATCH v3 05/12] usb: misc: ezusb: update to use usb_control_msg_send() Anant Thazhemadam
2021-01-27 14:52 ` Johan Hovold [this message]
2021-01-26 18:33 ` [PATCH v3 06/12] usb: misc: iowarrior: update to use the usb_control_msg_{send|recv}() API Anant Thazhemadam
2021-01-27 14:59 ` Johan Hovold
2021-01-26 18:33 ` [PATCH v3 07/12] usb: misc: isight_firmware: update to use usb_control_msg_send() Anant Thazhemadam
2021-01-27 15:04 ` Johan Hovold
2021-01-26 18:33 ` [PATCH v3 08/12] usb: misc: ldusb: " Anant Thazhemadam
2021-01-27 15:06 ` Johan Hovold
2021-01-26 18:39 ` [PATCH v3 09/12] usb: misc: lvstest: update to use the usb_control_msg_{send|recv}() API Anant Thazhemadam
2021-01-27 15:15 ` Johan Hovold
2021-01-26 18:40 ` [PATCH v3 10/12] usb: misc: trancevibrator: update to use usb_control_msg_send() Anant Thazhemadam
2021-01-27 15:17 ` Johan Hovold
2021-01-26 18:40 ` [PATCH v3 11/12] usb: misc: usbsevseg: " Anant Thazhemadam
2021-01-27 16:46 ` Johan Hovold
[not found] ` <20210126184043.915235-1-anant.thazhemadam@gmail.com>
2021-01-26 18:47 ` [PATCH v3 12/12] [PATCH v3 12/12] usb: misc: usbtest: update to use the, usb_control_msg_{send|recv}() API Anant Thazhemadam
2021-01-27 11:31 ` Greg Kroah-Hartman
2021-01-27 12:12 ` [RESEND PATCH v3 12/12] usb: misc: usbtest: update to use the " Anant Thazhemadam
2021-01-27 16:26 ` Alan Stern
2021-01-27 17:00 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBF+IFTNn4KMMVAw@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=anant.thazhemadam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).