From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: George Kennedy <george.kennedy@oracle.com>,
kasan-dev@googlegroups.com, glider@google.com,
dvyukov@google.com, aryabinin@virtuozzo.com
Cc: pjones@redhat.com, konrad@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] iscsi_ibft: KASAN false positive failure occurs in ibft_init()
Date: Wed, 27 Jan 2021 13:44:18 -0500 [thread overview]
Message-ID: <YBG0glwiK1wyJTeN@Konrads-MacBook-Pro.local> (raw)
In-Reply-To: <1611684201-16262-1-git-send-email-george.kennedy@oracle.com>
On Tue, Jan 26, 2021 at 01:03:21PM -0500, George Kennedy wrote:
> During boot of kernel with CONFIG_KASAN the following KASAN false
> positive failure will occur when ibft_init() reads the
> ACPI iBFT table: BUG: KASAN: use-after-free in ibft_init
>
> The ACPI iBFT table is not allocated, and the iscsi driver uses
> a pointer to it to calculate checksum, etc. KASAN complains
> about this pointer with use-after-free, which this is not.
>
Andrey, Alexander, Dmitry,
I think this is the right way for this, but was wondering if you have
other suggestions?
Thanks!
> Signed-off-by: George Kennedy <george.kennedy@oracle.com>
> ---
> drivers/firmware/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile
> index 5e013b6..30ddab5 100644
> --- a/drivers/firmware/Makefile
> +++ b/drivers/firmware/Makefile
> @@ -14,6 +14,9 @@ obj-$(CONFIG_INTEL_STRATIX10_SERVICE) += stratix10-svc.o
> obj-$(CONFIG_INTEL_STRATIX10_RSU) += stratix10-rsu.o
> obj-$(CONFIG_ISCSI_IBFT_FIND) += iscsi_ibft_find.o
> obj-$(CONFIG_ISCSI_IBFT) += iscsi_ibft.o
> +KASAN_SANITIZE_iscsi_ibft.o := n
> +KCOV_INSTRUMENT_iscsi_ibft.o := n
> +
> obj-$(CONFIG_FIRMWARE_MEMMAP) += memmap.o
> obj-$(CONFIG_RASPBERRYPI_FIRMWARE) += raspberrypi.o
> obj-$(CONFIG_FW_CFG_SYSFS) += qemu_fw_cfg.o
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2021-01-27 18:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 18:03 [PATCH 1/1] iscsi_ibft: KASAN false positive failure occurs in ibft_init() George Kennedy
2021-01-27 18:44 ` Konrad Rzeszutek Wilk [this message]
2021-01-27 18:48 ` Dmitry Vyukov
[not found] ` <cc712c9c-7786-bb26-7082-04e564df98aa@oracle.com>
2021-01-27 21:10 ` Dmitry Vyukov
2021-02-03 19:28 ` Konrad Rzeszutek Wilk
2021-02-03 19:35 ` Dmitry Vyukov
2021-02-10 21:51 ` George Kennedy
2021-02-12 13:30 ` George Kennedy
2021-02-12 13:51 ` Dmitry Vyukov
2021-02-12 15:36 ` David Hildenbrand
2021-02-12 18:05 ` George Kennedy
2021-01-27 20:47 George Kennedy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBG0glwiK1wyJTeN@Konrads-MacBook-Pro.local \
--to=konrad.wilk@oracle.com \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=george.kennedy@oracle.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).