From: Tejun Heo <tj@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Saravanan D <saravanand@fb.com>,
x86@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH V2] x86/mm: Tracking linear mapping split events
Date: Wed, 27 Jan 2021 16:36:32 -0500 [thread overview]
Message-ID: <YBHc4JHc4ogwV93W@slm.duckdns.org> (raw)
In-Reply-To: <5562757e-578b-0ad7-1a9c-c64238283ab7@intel.com>
Hello,
On Wed, Jan 27, 2021 at 01:32:03PM -0800, Dave Hansen wrote:
> >> arch/x86/mm/pat/set_memory.c | 117 ++++++++++++++++++++++++++++++++++
> >> include/linux/vm_event_item.h | 8 +++
> >> mm/vmstat.c | 8 +++
> >> 3 files changed, 133 insertions(+)
> >
> > So, now the majority of the added code is to add debugfs knobs which don't
> > provide anything that userland can't already do by simply reading the
> > monotonic counters.
> >
> > Dave, are you still set on the resettable counters?
>
> Not *really*. But, you either need them to be resettable, or you need
> to expect your users to take snapshots and compare changes over time.
> Considering how much more code it is, though, I'm not super attached to it.
Saravanan, can you please drop the debugfs portion and repost?
Thanks.
--
tejun
next prev parent reply other threads:[~2021-01-27 21:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BYAPR01MB40856478D5BE74CB6A7D5578CFBD9@BYAPR01MB4085.prod.exchangelabs.com>
2021-01-25 20:15 ` [PATCH] x86/mm: Tracking linear mapping split events since boot Dave Hansen
2021-01-25 20:32 ` Tejun Heo
2021-01-26 0:47 ` Dave Hansen
2021-01-26 0:53 ` Tejun Heo
2021-01-26 1:04 ` Dave Hansen
2021-01-26 1:17 ` Tejun Heo
2021-01-27 17:51 ` [PATCH V2] x86/mm: Tracking linear mapping split events Saravanan D
2021-01-27 21:03 ` Tejun Heo
2021-01-27 21:32 ` Dave Hansen
2021-01-27 21:36 ` Tejun Heo [this message]
2021-01-27 21:42 ` Saravanan D
2021-01-27 22:50 ` [PATCH V3] " Saravanan D
2021-01-27 23:00 ` Randy Dunlap
2021-01-27 23:56 ` Saravanan D
2021-01-27 23:41 ` Dave Hansen
2021-01-28 0:15 ` Saravanan D
2021-01-28 4:35 ` [PATCH V4] " Saravanan D
2021-01-28 4:51 ` Matthew Wilcox
[not found] ` <20210128104934.2916679-1-saravanand@fb.com>
2021-01-28 15:04 ` [PATCH V5] " Matthew Wilcox
2021-01-28 19:49 ` Saravanan D
2021-01-28 16:33 ` Zi Yan
2021-01-28 16:41 ` Dave Hansen
2021-01-28 16:56 ` Zi Yan
2021-01-28 16:59 ` Song Liu
[not found] ` <3aec2d10-f4c3-d07a-356f-6f1001679181@intel.com>
2021-01-28 21:20 ` Saravanan D
[not found] ` <20210128233430.1460964-1-saravanand@fb.com>
2021-01-28 23:41 ` [PATCH V6] " Tejun Heo
2021-01-29 19:27 ` Johannes Weiner
2021-02-08 23:17 ` Saravanan D
2021-02-08 23:30 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBHc4JHc4ogwV93W@slm.duckdns.org \
--to=tj@kernel.org \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=saravanand@fb.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).