From: Greg KH <gregkh@linuxfoundation.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: linux-kernel@vger.kernel.org, speakup@linux-speakup.org
Subject: Re: [PATCH] speakup: Make dectlk flush timeout configurable
Date: Thu, 28 Jan 2021 08:54:16 +0100 [thread overview]
Message-ID: <YBJtqGn/ZpdFpNlg@kroah.com> (raw)
In-Reply-To: <20210127234444.1038813-1-samuel.thibault@ens-lyon.org>
On Thu, Jan 28, 2021 at 12:44:44AM +0100, Samuel Thibault wrote:
> In case the serial port or cable got faulty, we may not be getting
> acknowledgements any more. The driver then currently waits for 4s to
> avoid jamming the device. This makes this delay configurable.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/accessibility/speakup/speakup_dectlk.c | 11 ++++++++++-
> drivers/accessibility/speakup/spk_types.h | 3 ++-
> drivers/accessibility/speakup/synth.c | 3 +++
> drivers/accessibility/speakup/varhandlers.c | 1 +
> 4 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/accessibility/speakup/speakup_dectlk.c b/drivers/accessibility/speakup/speakup_dectlk.c
> index d75de36..580ec79 100644
> --- a/drivers/accessibility/speakup/speakup_dectlk.c
> +++ b/drivers/accessibility/speakup/speakup_dectlk.c
> @@ -78,6 +78,8 @@ static struct kobj_attribute direct_attribute =
> __ATTR(direct, 0644, spk_var_show, spk_var_store);
> static struct kobj_attribute full_time_attribute =
> __ATTR(full_time, 0644, spk_var_show, spk_var_store);
> +static struct kobj_attribute flush_time_attribute =
> + __ATTR(flush_time, 0644, spk_var_show, spk_var_store);
__ATTR_RW()?
Also, no Documentation/ABI/ update for the new one user-visable
attribute? Please fix up.
thanks,
greg k-h
next prev parent reply other threads:[~2021-01-28 7:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 23:44 [PATCH] speakup: Make dectlk flush timeout configurable Samuel Thibault
2021-01-28 7:54 ` Greg KH [this message]
2021-01-28 17:55 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBJtqGn/ZpdFpNlg@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).