From: Stephan Gerhold <stephan@gerhold.net>
To: Vincent Knecht <vincent.knecht@mailoo.org>
Cc: phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Sam Ravnborg <sam@ravnborg.org>, Arnd Bergmann <arnd@arndb.de>,
Krzysztof Kozlowski <krzk@kernel.org>,
Shawn Guo <shawnguo@kernel.org>, Daniel Palmer <daniel@0x0f.com>,
Oleksij Rempel <linux@rempel-privat.de>,
Max Merchel <Max.Merchel@tq-group.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
allen <allen.chen@ite.com.tw>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: Disable MDSS by default for 8916/8016 devices
Date: Sat, 30 Jan 2021 12:28:24 +0100 [thread overview]
Message-ID: <YBVC2KfT4pLJ5/XX@gerhold.net> (raw)
In-Reply-To: <20210130105717.2628781-4-vincent.knecht@mailoo.org>
On Sat, Jan 30, 2021 at 11:57:12AM +0100, Vincent Knecht wrote:
> Disable MDSS (Mobile Display Subsystem) by default in msm8916.dtsi
> and only explicitly enable it in devices' DT which actually use it.
>
> This leads to faster boot and cleaner logs for other devices,
> which also won't have to explicitly disable MDSS to use framebuffer.
>
> Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
Thanks for the patch! I think this is a good thing because normally most
things are disabled by default in msm8916.dtsi (e.g. eMMC, SD card,
WCNSS, ....). Also, there are actually some devices that don't have a
display (e.g. the 4IoT board [1]). Having to disable it specifically is
kind of weird. So:
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
[1]: https://www.96boards.org/product/4iot/
> ---
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 4 ++++
> arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi | 4 ++++
> arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 +
> 3 files changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> index 3a9538e1ec97..6aef0c2e4f0a 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> @@ -301,6 +301,10 @@ &lpass {
> status = "okay";
> };
>
> +&mdss {
> + status = "okay";
> +};
> +
> &pm8916_resin {
> status = "okay";
> linux,code = <KEY_VOLUMEDOWN>;
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
> index f1af798abd74..230ba3ce3277 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
> @@ -132,6 +132,10 @@ &dsi0 {
> pinctrl-1 = <&mdss_sleep>;
> };
>
> +&mdss {
> + status = "okay";
> +};
> +
> &pm8916_resin {
> status = "okay";
> linux,code = <KEY_VOLUMEDOWN>;
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 402e891a84ab..8f9a651d3827 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -913,6 +913,7 @@ tcsr: syscon@1937000 {
> };
>
> mdss: mdss@1a00000 {
> + status = "disabled";
> compatible = "qcom,mdss";
> reg = <0x01a00000 0x1000>,
> <0x01ac8000 0x3000>;
> --
> 2.29.2
>
>
>
next prev parent reply other threads:[~2021-01-30 11:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 10:57 [PATCH v2 0/4] Alcatel Idol 3 (4.7") smartphone support Vincent Knecht
2021-01-30 10:57 ` [PATCH v2 1/4] dt-bindings: vendor-prefixes: add Alcatel Vincent Knecht
2021-01-30 10:57 ` [PATCH v2 2/4] arm64: dts: qcom: Add device tree for Alcatel Idol 3 (4.7") Vincent Knecht
2021-01-30 11:25 ` Stephan Gerhold
2021-01-30 15:45 ` Konrad Dybcio
2021-01-30 10:57 ` [PATCH v2 3/4] arm64: dts: qcom: Disable MDSS by default for 8916/8016 devices Vincent Knecht
2021-01-30 11:28 ` Stephan Gerhold [this message]
2021-01-30 15:40 ` Konrad Dybcio
2021-01-30 10:57 ` [PATCH v2 4/4] arm64: dts: qcom: msm8916-alcatel-idol347: Add framebuffer support Vincent Knecht
2021-01-30 15:42 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBVC2KfT4pLJ5/XX@gerhold.net \
--to=stephan@gerhold.net \
--cc=Max.Merchel@tq-group.com \
--cc=agross@kernel.org \
--cc=allen.chen@ite.com.tw \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=vincent.knecht@mailoo.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).