From: Johan Hovold <johan@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>, Miguel Ojeda <ojeda@kernel.org>,
Nick Desaulniers <ndesaulniers@gooogle.com>
Subject: Re: [PATCH] init: clean up early_param_on_off() macro
Date: Mon, 1 Feb 2021 10:27:21 +0100 [thread overview]
Message-ID: <YBfJeQC1jUeD2fdp@hovoldconsulting.com> (raw)
In-Reply-To: <20210201041532.4025025-1-masahiroy@kernel.org>
On Mon, Feb 01, 2021 at 01:15:32PM +0900, Masahiro Yamada wrote:
> Use early_param() to define early_param_on_off().
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> include/linux/init.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/init.h b/include/linux/init.h
> index e668832ef66a..ae2c2aace0d0 100644
> --- a/include/linux/init.h
> +++ b/include/linux/init.h
> @@ -277,14 +277,14 @@ struct obs_kernel_param {
> var = 1; \
> return 0; \
> } \
> - __setup_param(str_on, parse_##var##_on, parse_##var##_on, 1); \
> + early_param(str_on, parse_##var##_on); \
> \
> static int __init parse_##var##_off(char *arg) \
> { \
> var = 0; \
> return 0; \
> } \
> - __setup_param(str_off, parse_##var##_off, parse_##var##_off, 1)
> + early_param(str_off, parse_##var##_off)
>
> /* Relies on boot_command_line being set */
> void __init parse_early_param(void);
Looks good:
Reviewed-by: Johan Hovold <johan@kernel.org>
Johan
next prev parent reply other threads:[~2021-02-01 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 4:15 [PATCH] init: clean up early_param_on_off() macro Masahiro Yamada
2021-02-01 9:27 ` Johan Hovold [this message]
2021-02-01 15:58 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBfJeQC1jUeD2fdp@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@gooogle.com \
--cc=ojeda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).