From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C206C433E0 for ; Wed, 3 Feb 2021 19:37:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58CBA64E0D for ; Wed, 3 Feb 2021 19:37:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231153AbhBCThP (ORCPT ); Wed, 3 Feb 2021 14:37:15 -0500 Received: from mga01.intel.com ([192.55.52.88]:5950 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231296AbhBCThN (ORCPT ); Wed, 3 Feb 2021 14:37:13 -0500 IronPort-SDR: EjwDIsVy3c6WF00rPkdDgid8M99z0Vzt4GJwwIG4JJeYb/54V2BfjiATgnWxOG/aVFwHmMBl+L bqFx2YPcPDYw== X-IronPort-AV: E=McAfee;i="6000,8403,9884"; a="200070508" X-IronPort-AV: E=Sophos;i="5.79,399,1602572400"; d="scan'208";a="200070508" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2021 11:35:28 -0800 IronPort-SDR: wvqFBOGBv6TkhLjc0tjMG0iEkYLihlCupR907htdu1Pcsy0EU9gMdQL423diT2xYCi2JPIc9N0 0fN5E8iG8pTw== X-IronPort-AV: E=Sophos;i="5.79,399,1602572400"; d="scan'208";a="480464255" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2021 11:35:27 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1l7Nvw-001iG7-G8; Wed, 03 Feb 2021 21:35:24 +0200 Date: Wed, 3 Feb 2021 21:35:24 +0200 From: Andy Shevchenko To: Mario Limonciello Cc: Hans De Goede , Mark Gross , LKML , platform-driver-x86@vger.kernel.org Subject: Re: [PATCH] platform/x86: Move all dell drivers to their own subdirectory Message-ID: References: <20210203192637.2947540-1-mario.limonciello@dell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210203192637.2947540-1-mario.limonciello@dell.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 03, 2021 at 01:26:37PM -0600, Mario Limonciello wrote: > A user without a Dell system doesn't need to pick any of these > drivers. > > Suggested-by: Andy Shevchenko > Signed-off-by: Mario Limonciello You are fast, thanks! ... > +menuconfig DELL_X86_PLATFORM_DRIVERS I'm not sure this is a good order, rather X86_PLATFORM_DRIVERS_DELL? ... > +if DELL_X86_PLATFORM_DRIVERS > +source "drivers/platform/x86/dell/Kconfig" > +endif # DELL_X86_PLATFORM_DRIVERS Would you expect something else here? I would rather unconditionally source this and inside it do that menuconfig with ifdeffery. -- With Best Regards, Andy Shevchenko