linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arch: x86: kernel:  Mundane spelling fixes throughout the file apm_32.c
@ 2021-02-03 14:48 Bhaskar Chowdhury
  2021-02-03 16:49 ` Randy Dunlap
  0 siblings, 1 reply; 3+ messages in thread
From: Bhaskar Chowdhury @ 2021-02-03 14:48 UTC (permalink / raw)
  To: jikos, tglx, mingo, bp, x86, hpa, linux-kernel; +Cc: rdunlap, Bhaskar Chowdhury


s/messges/messages/
s/powermanagement/power management/
s/secodnds/seconds/
s/powerdown/poer down/

Capitalize and truncate space in start of the sentence.

Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
 arch/x86/kernel/apm_32.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c
index 660270359d39..04204e01ff7c 100644
--- a/arch/x86/kernel/apm_32.c
+++ b/arch/x86/kernel/apm_32.c
@@ -766,7 +766,7 @@ static int apm_driver_version(u_short *val)
  *	not cleared until it is acknowledged.
  *
  *	Additional information is returned in the info pointer, providing
- *	that APM 1.2 is in use. If no messges are pending the value 0x80
+ *	that APM 1.2 is in use. If no messages are pending the value 0x80
  *	is returned (No power management events pending).
  */
 static int apm_get_event(apm_event_t *event, apm_eventinfo_t *info)
@@ -893,7 +893,7 @@ static void apm_do_busy(void)
  * apm_cpu_idle		-	cpu idling for APM capable Linux
  *
  * This is the idling function the kernel executes when APM is available. It
- * tries to do BIOS powermanagement based on the average system idle time.
+ * tries to do BIOS power management based on the average system idle time.
  * Furthermore it calls the system default idle routine.
  */

@@ -1025,7 +1025,7 @@ static int apm_enable_power_management(int enable)
  *	status which gives the rough battery status, and current power
  *	source. The bat value returned give an estimate as a percentage
  *	of life and a status value for the battery. The estimated life
- *	if reported is a lifetime in secodnds/minutes at current powwer
+ *	if reported is a lifetime in seconds/minutes at current power
  *	consumption.
  */

@@ -1121,7 +1121,7 @@ static int apm_engage_power_management(u_short device, int enable)
  *	Attempt to blank the console, firstly by blanking just video device
  *	zero, and if that fails (some BIOSes don't support it) then it blanks
  *	all video devices. Typically the BIOS will do laptop backlight and
- *	monitor powerdown for us.
+ *	monitor power down for us.
  */

 static int apm_console_blank(int blank)
@@ -2366,7 +2366,7 @@ static int __init apm_init(void)
 	/*
 	 * Note we don't actually care if the misc_device cannot be registered.
 	 * this driver can do its job without it, even if userspace can't
-	 * control it.  just log the error
+	 * control it.Just log the error
 	 */
 	if (misc_register(&apm_device))
 		printk(KERN_WARNING "apm: Could not register misc device.\n");
--
2.26.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arch: x86: kernel: Mundane spelling fixes throughout the file apm_32.c
  2021-02-03 14:48 [PATCH] arch: x86: kernel: Mundane spelling fixes throughout the file apm_32.c Bhaskar Chowdhury
@ 2021-02-03 16:49 ` Randy Dunlap
  2021-02-04  0:08   ` Bhaskar Chowdhury
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2021-02-03 16:49 UTC (permalink / raw)
  To: Bhaskar Chowdhury, jikos, tglx, mingo, bp, x86, hpa, linux-kernel

On 2/3/21 6:48 AM, Bhaskar Chowdhury wrote:
> 
> s/messges/messages/
> s/powermanagement/power management/
> s/secodnds/seconds/
> s/powerdown/poer down/
> 
> Capitalize and truncate space in start of the sentence.
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
>  arch/x86/kernel/apm_32.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c
> index 660270359d39..04204e01ff7c 100644
> --- a/arch/x86/kernel/apm_32.c
> +++ b/arch/x86/kernel/apm_32.c
> @@ -2366,7 +2366,7 @@ static int __init apm_init(void)
>  	/*
>  	 * Note we don't actually care if the misc_device cannot be registered.
>  	 * this driver can do its job without it, even if userspace can't
> -	 * control it.  just log the error
> +	 * control it.Just log the error

missing space and period:

	 * control it. Just log the error.

The rest of the changes look good.

Thanks.

>  	 */
>  	if (misc_register(&apm_device))
>  		printk(KERN_WARNING "apm: Could not register misc device.\n");
> --
> 2.26.2
> 


-- 
~Randy


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arch: x86: kernel: Mundane spelling fixes throughout the file apm_32.c
  2021-02-03 16:49 ` Randy Dunlap
@ 2021-02-04  0:08   ` Bhaskar Chowdhury
  0 siblings, 0 replies; 3+ messages in thread
From: Bhaskar Chowdhury @ 2021-02-04  0:08 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: jikos, tglx, mingo, bp, x86, hpa, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

On 08:49 Wed 03 Feb 2021, Randy Dunlap wrote:
>On 2/3/21 6:48 AM, Bhaskar Chowdhury wrote:
>>
>> s/messges/messages/
>> s/powermanagement/power management/
>> s/secodnds/seconds/
>> s/powerdown/poer down/
>>
>> Capitalize and truncate space in start of the sentence.
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>>  arch/x86/kernel/apm_32.c | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c
>> index 660270359d39..04204e01ff7c 100644
>> --- a/arch/x86/kernel/apm_32.c
>> +++ b/arch/x86/kernel/apm_32.c
>> @@ -2366,7 +2366,7 @@ static int __init apm_init(void)
>>  	/*
>>  	 * Note we don't actually care if the misc_device cannot be registered.
>>  	 * this driver can do its job without it, even if userspace can't
>> -	 * control it.  just log the error
>> +	 * control it.Just log the error
>
>missing space and period:
>
>	 * control it. Just log the error.
>
>The rest of the changes look good.
>

My bad...thank you Randy!
>Thanks.
>
>>  	 */
>>  	if (misc_register(&apm_device))
>>  		printk(KERN_WARNING "apm: Could not register misc device.\n");
>> --
>> 2.26.2
>>
>
>
>--
>~Randy
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-04  0:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 14:48 [PATCH] arch: x86: kernel: Mundane spelling fixes throughout the file apm_32.c Bhaskar Chowdhury
2021-02-03 16:49 ` Randy Dunlap
2021-02-04  0:08   ` Bhaskar Chowdhury

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).