From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92CD9C433E0 for ; Thu, 4 Feb 2021 06:31:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 592EB61477 for ; Thu, 4 Feb 2021 06:31:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232686AbhBDGbl (ORCPT ); Thu, 4 Feb 2021 01:31:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:42434 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232623AbhBDGbj (ORCPT ); Thu, 4 Feb 2021 01:31:39 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E53CC64DFF; Thu, 4 Feb 2021 06:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612420258; bh=KiqsDmwoOQBWMdKETEVcciZtR/5mNdfe3xrYoqgAiew=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sXBLYF+4J1h7scQUbCEycVWnDj7dmRPygVWhY8ghGCWTCEBd7RLxBAEpozurtLn+k gRz+moIQpZpbfIGkn6KD5zAtYR/FM6Y8DH7zdehq2QtaRkihnLO0I8bM7Eu+fJD1ai Rot1O8jvr1w+iGzbHvOEPV8g6ZqpuW+UhZF2l4pc= Date: Thu, 4 Feb 2021 07:30:55 +0100 From: Greg Kroah-Hartman To: Pawel Laszczak Cc: Dan Carpenter , Colin King , "linux-usb@vger.kernel.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH][next] usb: cdnsp: Fix spelling mistake "delagete" -> "delegate" Message-ID: References: <20210203111239.18313-1-colin.king@canonical.com> <20210203130440.GV2696@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 04, 2021 at 05:07:16AM +0000, Pawel Laszczak wrote: > Hi Dan, > > >> From: Colin Ian King > >> > >> There is a spelling mistake in a literal string. Fix it. > >> > >> Signed-off-by: Colin Ian King > >> --- > >> drivers/usb/cdns3/cdnsp-ep0.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/usb/cdns3/cdnsp-ep0.c b/drivers/usb/cdns3/cdnsp-ep0.c > >> index e2b1bcb3f80e..e30931ebc870 100644 > >> --- a/drivers/usb/cdns3/cdnsp-ep0.c > >> +++ b/drivers/usb/cdns3/cdnsp-ep0.c > >> @@ -45,7 +45,7 @@ static int cdnsp_ep0_delegate_req(struct cdnsp_device *pdev, > >> { > >> int ret; > >> > >> - trace_cdnsp_ep0_request("delagete"); > >> + trace_cdnsp_ep0_request("delegate"); > >> > > > >This printk is useless and should just be deleted. Use ftrace instead. > > Maybe this printk is redundant but it's more comfortable in use. > To debug I can simply enable cdns-dev events (echo cdnsp-dev:* > set_event) > and I will get the full picture of what the driver is doing. > > Otherwise, I must remember which function I need to add to set_ftrace_filter. > Of course, by default I can simply add all cdnsp* functions (echo cdnsp* > set_ftrace_filter) but it > increases the trace log and makes it a little more difficult to analyze. > > So maybe in some cases we shouldn't complain for such printk ? > > It's my private opinion and not necessarily correct :) Please don't have duplicate tracepoints for something like "this function is now called", it's redundant. thanks, greg k-h