From: Peter Zijlstra <peterz@infradead.org>
To: Alexey Klimov <aklimov@redhat.com>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
yury.norov@gmail.com, daniel.m.jordan@oracle.com,
tglx@linutronix.de, jobaker@redhat.com, audralmitchel@gmail.com,
arnd@arndb.de, gregkh@linuxfoundation.org, rafael@kernel.org,
tj@kernel.org, lizefan@huawei.com, qais.yousef@arm.com,
hannes@cmpxchg.org, klimov.linux@gmail.com
Subject: Re: [PATCH] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu onlining
Date: Thu, 4 Feb 2021 10:46:10 +0100 [thread overview]
Message-ID: <YBvCYhdPai+pb8u2@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210204010157.1823669-1-aklimov@redhat.com>
On Thu, Feb 04, 2021 at 01:01:57AM +0000, Alexey Klimov wrote:
> @@ -1281,6 +1282,11 @@ static int cpu_up(unsigned int cpu, enum cpuhp_state target)
> err = _cpu_up(cpu, 0, target);
> out:
> cpu_maps_update_done();
> +
> + /* To avoid out of line uevent */
> + if (!err)
> + cpuset_wait_for_hotplug();
> +
> return err;
> }
>
> @@ -2071,14 +2075,18 @@ static void cpuhp_online_cpu_device(unsigned int cpu)
> struct device *dev = get_cpu_device(cpu);
>
> dev->offline = false;
> - /* Tell user space about the state change */
> - kobject_uevent(&dev->kobj, KOBJ_ONLINE);
> }
>
One concequence of this is that you'll now get a bunch of notifications
across things like suspend/hybernate.
next prev parent reply other threads:[~2021-02-04 9:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 1:01 [PATCH] cpu/hotplug: wait for cpuset_hotplug_work to finish on cpu onlining Alexey Klimov
2021-02-04 9:46 ` Peter Zijlstra [this message]
2021-02-04 12:50 ` Alexey Klimov
2021-02-04 13:42 ` Peter Zijlstra
2021-02-05 0:39 ` Daniel Jordan
2021-02-11 14:09 ` Alexey Klimov
2021-02-05 11:22 ` Qais Yousef
2021-02-11 13:38 ` Alexey Klimov
2021-02-05 1:35 ` Daniel Jordan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBvCYhdPai+pb8u2@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aklimov@redhat.com \
--cc=arnd@arndb.de \
--cc=audralmitchel@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=daniel.m.jordan@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=jobaker@redhat.com \
--cc=klimov.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=qais.yousef@arm.com \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).