From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC3A8C43381 for ; Thu, 4 Feb 2021 20:33:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5AD8564F48 for ; Thu, 4 Feb 2021 20:33:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240179AbhBDUdQ (ORCPT ); Thu, 4 Feb 2021 15:33:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240134AbhBDU3T (ORCPT ); Thu, 4 Feb 2021 15:29:19 -0500 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16261C061786 for ; Thu, 4 Feb 2021 12:28:39 -0800 (PST) Received: by mail-qk1-x72f.google.com with SMTP id s77so4716336qke.4 for ; Thu, 04 Feb 2021 12:28:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yEvjhfE3B2Kd/et2YVJ5Ze7JfgA4snxVhFv0VxIo/SQ=; b=Ef7g7l18hq99xrkcC+S5rDk+Sp9Ldd0vt7jDuvrHK+Le50wfK90SOFztyYrf29ifLe biWfx67fF91Fo4nuJXl2iOm7tcA5jlLMrrnX0D+3B9Ndg3icZNqZOICzMoJMwChxhotz ySXUYjeFoyjJFXTjFmRy3AantGbnhjZfjnqNpAOPW7uqhIer8dTEpVZI6xP+NJj8ifhj dQwk76TLSuj9GGbU0nKkHxEBfRChrDAOVoKePjDl+pEWX/l7t+2k2sl9PhMwJtWH84Pw KnlHlf90OKa1gmp1WYk/YCl5MQ4QBIGmt1ubhQioYN5H51o23sks0+4aCN9r9Y8WK8Hs v3Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yEvjhfE3B2Kd/et2YVJ5Ze7JfgA4snxVhFv0VxIo/SQ=; b=fvrn4NUtNZHdXmq/Pyr8unQ/TL4zbpb4TeHpPe8nTSIM7EddTxwjpB3+8WdHpy4xIV CBruZzpfIviXTRBKa7oHJFqeexCtwtlhecDfUNkk46qkSqGeAFMQUiYQSXjt1llsbBRJ CuuIcm/fyTn9W0Dvjn2vL6kjEk70wK23zK2WFVyOl0VV0wTUtqf4iA8ymTBxhbfom/Dw CFJ0moF9RsgpOVv8Tvs+/3lZmx/KWzzjL3tKNIFCuamxBFKE9iRbM3gThLVDDKHXjTrr F52fR8zdRRU0ANoh3jzIeR2uwdaa4RD46OTbZ+9uXIpZDOtIPRSlZrJ512kEzagAdClc /kGg== X-Gm-Message-State: AOAM530xEPzLBXj41IqO1ZIQ6vE7oZpNaUd/B0T8CzeHln9vmqFyIh6r F6MCB6x64e0mSXAXOKA0+nLlOQ== X-Google-Smtp-Source: ABdhPJzRivD82L4tmvBPLrKvgq8taLN8T8Z/XRbao2O58AtODRS6pP2wpZ/weDptlT9GSYNpBdL0Mg== X-Received: by 2002:a37:6f06:: with SMTP id k6mr1003338qkc.458.1612470518352; Thu, 04 Feb 2021 12:28:38 -0800 (PST) Received: from localhost (70.44.39.90.res-cmts.bus.ptd.net. [70.44.39.90]) by smtp.gmail.com with ESMTPSA id b203sm5920262qkg.26.2021.02.04.12.28.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 12:28:37 -0800 (PST) Date: Thu, 4 Feb 2021 15:28:36 -0500 From: Johannes Weiner To: Michal Hocko Cc: Andrew Morton , Tejun Heo , Roman Gushchin , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 6/7] mm: memcontrol: switch to rstat Message-ID: References: <20210202184746.119084-1-hannes@cmpxchg.org> <20210202184746.119084-7-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 04, 2021 at 05:44:06PM +0100, Michal Hocko wrote: > On Thu 04-02-21 11:15:06, Johannes Weiner wrote: > > Hello Michal, > > > > On Thu, Feb 04, 2021 at 03:19:17PM +0100, Michal Hocko wrote: > > > On Tue 02-02-21 13:47:45, Johannes Weiner wrote: > > > > Replace the memory controller's custom hierarchical stats code with > > > > the generic rstat infrastructure provided by the cgroup core. > > > > > > > > The current implementation does batched upward propagation from the > > > > write side (i.e. as stats change). The per-cpu batches introduce an > > > > error, which is multiplied by the number of subgroups in a tree. In > > > > systems with many CPUs and sizable cgroup trees, the error can be > > > > large enough to confuse users (e.g. 32 batch pages * 32 CPUs * 32 > > > > subgroups results in an error of up to 128M per stat item). This can > > > > entirely swallow allocation bursts inside a workload that the user is > > > > expecting to see reflected in the statistics. > > > > > > > > In the past, we've done read-side aggregation, where a memory.stat > > > > read would have to walk the entire subtree and add up per-cpu > > > > counts. This became problematic with lazily-freed cgroups: we could > > > > have large subtrees where most cgroups were entirely idle. Hence the > > > > switch to change-driven upward propagation. Unfortunately, it needed > > > > to trade accuracy for speed due to the write side being so hot. > > > > > > > > Rstat combines the best of both worlds: from the write side, it > > > > cheaply maintains a queue of cgroups that have pending changes, so > > > > that the read side can do selective tree aggregation. This way the > > > > reported stats will always be precise and recent as can be, while the > > > > aggregation can skip over potentially large numbers of idle cgroups. > > > > > > > > This adds a second vmstats to struct mem_cgroup (MEMCG_NR_STAT + > > > > NR_VM_EVENT_ITEMS) to track pending subtree deltas during upward > > > > aggregation. It removes 3 words from the per-cpu data. It eliminates > > > > memcg_exact_page_state(), since memcg_page_state() is now exact. > > > > > > I am still digesting details and need to look deeper into how rstat > > > works but removing our own stats is definitely a good plan. Especially > > > when there are existing limitations and problems that would need fixing. > > > > > > Just to check that my high level understanding is correct. The > > > transition is effectivelly removing a need to manually sync counters up > > > the hierarchy and partially outsources that decision to rstat core. The > > > controller is responsible just to tell the core how that syncing is done > > > (e.g. which specific counters etc). > > > > Yes, exactly. > > > > rstat implements a tree of cgroups that have local changes pending, > > and a flush walk on that tree. But it's all driven by the controller. > > > > memcg needs to tell rstat 1) when stats in a local cgroup change > > e.g. when we do mod_memcg_state() (cgroup_rstat_updated), 2) when to > > flush, e.g. before a memory.stat read (cgroup_rstat_flush), and 3) how > > to flush one cgroup's per-cpu state and propagate it upward to the > > parent during rstat's flush walk (.css_rstat_flush). > > Can we have this short summary in a changelog please? Sure thing, I'll include that v2. > > > Excplicit flushes are needed when you want an exact value (e.g. when > > > values are presented to the userspace). I do not see any flushes to > > > be done by the core pro-actively except for clean up on a release. > > > > > > Is the above correct understanding? > > > > Yes, that's correct. > > OK, thanks for the confirmation. I will have a closer look tomorrow but > I do not see any problems now. Thanks