From: Chris Down <chris@chrisdown.name>
To: linux-kernel@vger.kernel.org
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
John Ogness <john.ogness@linutronix.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
kernel-team@fb.com
Subject: Re: [PATCH] printk: Userspace format enumeration support
Date: Fri, 5 Feb 2021 00:47:58 +0000 [thread overview]
Message-ID: <YByVvsFL5/X/+kLc@chrisdown.name> (raw)
In-Reply-To: <YBwU0G+P0vb9wTwm@chrisdown.name>
Some improvements I noticed that I'll include when sending v2.
Chris Down writes:
>+static void remove_printk_fmt_sec(const struct module *mod)
>+{
>+ struct printk_fmt_sec *tmp = NULL, *ps = NULL;
>+ const char **fptr = NULL;
fptr can be scoped to list_for_each_entry_safe, I'll move it.
>+static int proc_pf_show(struct seq_file *s, void *v)
>+{
>+ const struct printk_fmt_sec *ps = NULL;
>+ const char **fptr = NULL;
Ditto for list_for_each_entry.
>+
>+ mutex_lock(&printk_fmts_mutex);
>+
>+ list_for_each_entry(ps, &printk_fmts_list, list) {
>+ const char *mod_name = ps_get_module_name(ps);
>+
>+ for (fptr = ps->start; fptr < ps->end; fptr++) {
>+ seq_puts(s, mod_name);
>+ seq_putc(s, ',');
>+ seq_puts(s, *fptr);
>+ seq_putc(s, '\0');
>+ }
>+ }
Not sure why I didn't just use seq_printf here. I'll do that.
I'll wait a few days for feedback then will send v2 either way. :-)
next prev parent reply other threads:[~2021-02-05 0:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 15:37 [PATCH] printk: Userspace format enumeration support Chris Down
2021-02-05 0:47 ` Chris Down [this message]
2021-02-05 14:26 ` Chris Down
2021-02-05 16:42 ` Petr Mladek
2021-02-05 17:47 ` Steven Rostedt
2021-02-05 22:45 ` Chris Down
2021-02-05 22:49 ` Steven Rostedt
2021-02-06 7:13 ` Greg Kroah-Hartman
2021-02-06 12:44 ` Chris Down
2021-02-05 22:25 ` Chris Down
2021-02-06 17:57 ` Joe Perches
2021-02-06 21:21 ` Chris Down
2021-02-07 4:41 ` Joe Perches
2021-02-07 14:13 ` Chris Down
2021-02-07 14:58 ` Joe Perches
2021-02-07 16:13 ` Chris Down
2021-02-07 16:53 ` Chris Down
2021-02-07 22:21 ` kernel test robot
2021-02-08 1:13 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YByVvsFL5/X/+kLc@chrisdown.name \
--to=chris@chrisdown.name \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=john.ogness@linutronix.de \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).