From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FEC8C433E0 for ; Fri, 5 Feb 2021 02:05:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 427C964F8C for ; Fri, 5 Feb 2021 02:05:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229777AbhBECFJ (ORCPT ); Thu, 4 Feb 2021 21:05:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:41540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229751AbhBECFH (ORCPT ); Thu, 4 Feb 2021 21:05:07 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id AB18064F8C; Fri, 5 Feb 2021 02:04:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612490667; bh=a5SkZ9ToIlPVKBvkHANzaTJxWRyFUM3+72lidawO2FY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X3ATyfTJrUwcqOdjrKuEuX5MLQcxkUZ3biRRym+9vVyHOfWnfwDhKgS9g3AXpT4fn 04EKJ9iY8MRWsD1twEOxYn9oigEYG1ZGNQuktOIsoXPculhwKciwqWRbB11FdKnpt3 4TMzk5kexC+uax+jT6zOQ5RmxA5oJmsY3HRTDEo4gxTeiiLrXXeazS+RbI6hZX0mCm tN88+Wvtcn/Or92HO4Pc5SBjJJE0gZcNsYnGVs+JKrq4oiQFxJoGEJfHyf0bscwxQe rqUhsorSQDuA/rCIq1tSu55ji8hFm+xa3YV6KEvphU1mUWn27+JVa80neTkjXxTlZ7 3+onlWT6k3vkQ== Date: Fri, 5 Feb 2021 04:04:18 +0200 From: Jarkko Sakkinen To: Rikard Falkeborn Cc: Peter Huewe , Jason Gunthorpe , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm/ppi: Constify static struct attribute_group Message-ID: References: <20210204215427.49047-1-rikard.falkeborn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210204215427.49047-1-rikard.falkeborn@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 04, 2021 at 10:54:27PM +0100, Rikard Falkeborn wrote: > The only usage of ppi_attr_grp is to put its address in an array of > pointers to const struct attribute_group. Make it const to allow the > compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn Thanks. Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/tpm_ppi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_ppi.c b/drivers/char/tpm/tpm_ppi.c > index b2dab941cb7f..40018a73b3cb 100644 > --- a/drivers/char/tpm/tpm_ppi.c > +++ b/drivers/char/tpm/tpm_ppi.c > @@ -358,7 +358,7 @@ static struct attribute *ppi_attrs[] = { > &dev_attr_tcg_operations.attr, > &dev_attr_vs_operations.attr, NULL, > }; > -static struct attribute_group ppi_attr_grp = { > +static const struct attribute_group ppi_attr_grp = { > .name = "ppi", > .attrs = ppi_attrs > }; > -- > 2.30.0 > >