From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C694C433DB for ; Fri, 19 Feb 2021 14:53:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCED364EB2 for ; Fri, 19 Feb 2021 14:53:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229828AbhBSOxB (ORCPT ); Fri, 19 Feb 2021 09:53:01 -0500 Received: from mga06.intel.com ([134.134.136.31]:32372 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbhBSOws (ORCPT ); Fri, 19 Feb 2021 09:52:48 -0500 IronPort-SDR: KWc+tMYChgqo4VL925+ofOw8AQKM0QQbAKDUxYgsY6CgS9eJd9+EjlZvArtDReJn2YYCMpdfsp VgsfQc1L04tg== X-IronPort-AV: E=McAfee;i="6000,8403,9899"; a="245297940" X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="245297940" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2021 06:51:00 -0800 IronPort-SDR: XNsOsLS/6p2KI9BVXBS0S5Q0fHuqsTaIzWVr3TOnxt9tTdXzgYEdkRsgSXs/UsPjRp3R4SeSVz p2GCd5Zc5jBA== X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="440289014" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2021 06:50:58 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lD77Q-006Ehe-5C; Fri, 19 Feb 2021 16:50:56 +0200 Date: Fri, 19 Feb 2021 16:50:56 +0200 From: Andy Shevchenko To: Sven Schuchmann , Linus Walleij Cc: Pavel Machek , Dan Murphy , "linux-leds@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT Message-ID: References: <20210204143738.28036-1-schuchmann@schleissheimer.de> <20210204145308.GC14305@duo.ucw.cz> <20210205103438.GB27854@amd> <20210219111659.GI19207@duo.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 19, 2021 at 02:09:03PM +0000, Sven Schuchmann wrote: > > Von: Andy Shevchenko > > Gesendet: Freitag, 19. Februar 2021 14:56 > > > > > > Can you or Dan submit patch getting the regulator support to work? If > > > > > > not, I guess we should remove the regulator support after all. > > > > > > > > > > To be true I am fairly new to the kernel and have no idea > > > > > how to test this. So no, I don't want provide a patch (except > > > > > for removing), sorry. > > > > > > > > No problem. It seems Andy submitted series for this. > > > > > > > > > > To me it seems that patches from Andy don't make > > > the regulator work. Maybe I am wrong? > > > > I;m not sure I understand this correctly. Do you mean that my patches broke > > something? Which one explicitly and what is broken? > > No, your patches do not break something (as far as I can see). > Pavel asked for a patch to fix the regulator. The regulator > at this time is only initialized but never used in the lp50xx. > I told him (see above) that I cannot provide a patch which > fixes this. He answered that you fixed this in your series, > but to me it doesn't seem so. > or did you fix the regulator usage in your patch series? No, I haven't touched regulator and I see now what is there. One may add some code, I know Linus did it in many places, maybe he can help to have done this properly? -- With Best Regards, Andy Shevchenko