From: Johannes Weiner <hannes@cmpxchg.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Chris Down <chris@chrisdown.name>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
John Ogness <john.ogness@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
kernel-team@fb.com
Subject: Re: code style: Re: [PATCH v4] printk: Userspace format enumeration support
Date: Wed, 17 Feb 2021 11:00:18 -0500 [thread overview]
Message-ID: <YC09kt7Lo9iqAEOp@cmpxchg.org> (raw)
In-Reply-To: <YC06LyPGmytXJ8Iu@alley>
On Wed, Feb 17, 2021 at 04:45:51PM +0100, Petr Mladek wrote:
> On Tue 2021-02-16 21:05:48, Chris Down wrote:
> > Johannes Weiner writes:
> > > On Tue, Feb 16, 2021 at 05:27:08PM +0000, Chris Down wrote:
> > > > Petr Mladek writes:
> > > > > I wonder if we could find a better name for the configure switch.
> > > > > I have troubles to imagine what printk enumeration might mean.
> > > > > Well, it might be because I am not a native speaker.
> > > > >
> > > > > Anyway, the word "enumeration" is used only in the configure option.
> > > > > Everything else is "printk_fmt"
> > > > >
> > > > > What about DEBUG_PRINTK_FORMATS?
> > > >
> > > > Hmm, I don't like DEBUG_PRINTK_FMTS because it's not about debugging, it's
> > > > about enumeration, I guess :-)
> > > >
> > > > The name should reflect that this catalogues the available printks in the
> > > > kernel -- "debugging" seems to imply something different.
> > > >
> > > > I'm ok with a different name like "printk catalogue" or something like that
> > > > if you prefer. Personally I think "printk enumeration" is fairly clear --
> > > > it's about enumerating the available printks -- but anything that captures
> > > > that spirit is fine.
> > >
> > > How about config PRINTK_INDEX?
> >
> > Ah yes, I also like that. PRINTK_INDEX is fine from my perspective and is
> > more straightforward than "enumeration", thanks.
>
> It is better than enumeration. But there is still the same
> problem. The word "index" is used neither in the code
> nor in the debugfs interface. It is like enabling cars and
> seeing apples.
I assumed code and interface would then also be changed to
printk_index, struct printk_index_section, pi_foo, ...
next prev parent reply other threads:[~2021-02-17 16:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 15:30 [PATCH v4] printk: Userspace format enumeration support Chris Down
2021-02-12 18:01 ` kernel test robot
2021-02-13 14:29 ` Chris Down
2021-02-13 15:15 ` Chris Down
2021-02-16 15:53 ` output: was: " Petr Mladek
2021-02-16 16:52 ` Chris Down
2021-02-17 14:27 ` Petr Mladek
2021-02-17 15:28 ` Chris Down
2021-02-17 19:17 ` Steven Rostedt
2021-02-17 21:23 ` Chris Down
2021-02-18 11:34 ` Petr Mladek
2021-02-16 16:00 ` debugfs: " Petr Mladek
2021-02-16 17:18 ` Chris Down
2021-02-17 15:35 ` Petr Mladek
2021-02-17 15:49 ` Chris Down
2021-02-16 17:14 ` code style: " Petr Mladek
2021-02-16 17:27 ` Chris Down
2021-02-16 21:00 ` Johannes Weiner
2021-02-16 21:05 ` Chris Down
2021-02-17 15:45 ` Petr Mladek
2021-02-17 15:56 ` Chris Down
2021-02-18 10:58 ` Petr Mladek
2021-02-17 16:00 ` Johannes Weiner [this message]
2021-02-17 16:09 ` Petr Mladek
2021-02-17 16:25 ` Chris Down
2021-02-17 16:32 ` Chris Down
2021-02-18 10:45 ` Petr Mladek
2021-02-18 12:21 ` Chris Down
2021-02-18 12:37 ` Petr Mladek
2021-02-18 12:41 ` Chris Down
2021-02-18 14:25 ` Petr Mladek
2021-02-18 15:53 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC09kt7Lo9iqAEOp@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=chris@chrisdown.name \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=keescook@chromium.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).