From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Ronald Tschalär" <ronald@innovation.ch>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Sergiu Cuciurean <sergiu.cuciurean@analog.com>,
Lee Jones <lee.jones@linaro.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Input: applespi: Don't wait for responses to commands indefinitely.
Date: Wed, 17 Feb 2021 12:23:23 -0800 [thread overview]
Message-ID: <YC17OycMiNipMUyn@google.com> (raw)
In-Reply-To: <20210217190718.11035-1-ronald@innovation.ch>
Hi Ronald,
On Wed, Feb 17, 2021 at 11:07:16AM -0800, Ronald Tschalär wrote:
> @@ -869,7 +878,7 @@ static int applespi_send_cmd_msg(struct applespi_data *applespi)
> return sts;
> }
>
> - applespi->cmd_msg_queued = true;
> + applespi->cmd_msg_queued = ktime_get();
Will it be OK if I change this to ktime_get_coarse()? I do not think we
need exact time here, and the coarse variant is cheaper I believe.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-02-17 20:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 19:07 [PATCH 1/3] Input: applespi: Don't wait for responses to commands indefinitely Ronald Tschalär
2021-02-17 19:07 ` [PATCH 2/3] Input: applespi: Fix occasional crc errors under load Ronald Tschalär
2021-02-19 19:12 ` Dmitry Torokhov
2021-02-17 19:07 ` [PATCH 3/3] Input: applespi: Add trace_event module param for early tracing Ronald Tschalär
2021-02-17 20:26 ` Dmitry Torokhov
2021-02-17 20:52 ` Life is hard, and then you die
2021-02-17 21:06 ` Dmitry Torokhov
2021-02-17 22:34 ` Life is hard, and then you die
2021-02-18 0:18 ` kernel test robot
2021-02-18 4:41 ` kernel test robot
2021-02-17 20:23 ` Dmitry Torokhov [this message]
2021-02-17 20:45 ` [PATCH 1/3] Input: applespi: Don't wait for responses to commands indefinitely Life is hard, and then you die
2021-02-19 19:12 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC17OycMiNipMUyn@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=gustavoars@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ronald@innovation.ch \
--cc=sergiu.cuciurean@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).