linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Michael Walle <michael@walle.cc>
Cc: linux-kernel@vger.kernel.org, maz@kernel.org, tglx@linutronix.de
Subject: Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain
Date: Thu, 18 Feb 2021 09:40:58 +0100	[thread overview]
Message-ID: <YC4oGsBTyMJrGJ9C@kroah.com> (raw)
In-Reply-To: <20210217195717.13727-1-michael@walle.cc>

On Wed, Feb 17, 2021 at 08:57:17PM +0100, Michael Walle wrote:
> Hi Greg,
> 
> > There's no need to keep around a dentry pointer to a simple file that
> > debugfs itself can look up when we need to remove it from the system.
> > So simplify the code by deleting the variable and cleaning up the logic
> > around the debugfs file.
> 
> This will generate the following oops on my board (arm64,
> freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts). In debugfs_lookup()
> debugfs_mount is NULL.
> 
> [    0.000000] Linux version 5.11.0-next-20210217-00014-g41e0e92a2d05 (mwalle@mwalle01) (aarch64-linux-gnu-gcc (Debian 8.3.0-2) 8.3.0, GNU ld (GNU Binutils for Debian) 2.31.1) #69 SMP PREEMPT Wed Feb 17 20:47:10 CET 2021
> [..]
> [    0.000000] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000
> [    0.000000] Mem abort info:
> [    0.000000]   ESR = 0x96000004

<snip>

Back to this log, do you see:
	"Unable to pin filesystem for file "
anywhere before this crash?

thanks,

greg k-h

  parent reply	other threads:[~2021-02-18  9:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 14:36 [PATCH] irqdomain: remove debugfs_file from struct irq_domain Greg Kroah-Hartman
2021-02-16 15:36 ` [irqchip: irq/irqchip-next] irqdomain: Remove " irqchip-bot for Greg Kroah-Hartman
2021-02-17 19:57 ` [PATCH] irqdomain: remove " Michael Walle
2021-02-17 20:02   ` Marc Zyngier
2021-02-17 20:10     ` Michael Walle
2021-02-17 21:50       ` Marc Zyngier
2021-02-17 22:21         ` Michael Walle
2021-02-18  7:16           ` Greg KH
2021-02-18  7:31         ` Greg KH
2021-02-18  8:27           ` Michael Walle
2021-02-18  8:38             ` Greg KH
2021-02-18  8:47               ` Marc Zyngier
2021-02-18  8:54                 ` Greg KH
2021-02-18  9:04                   ` Marc Zyngier
2021-02-18  9:38                     ` Greg KH
2021-02-18 10:39                       ` Marc Zyngier
2021-02-18  8:52             ` Greg KH
2021-02-18  9:04               ` Michael Walle
2021-02-18  9:08               ` Marc Zyngier
2021-02-18  8:40   ` Greg KH [this message]
2021-02-18  8:46     ` Michael Walle
2021-02-18 11:43 ` [irqchip: irq/irqchip-next] irqdomain: Remove " irqchip-bot for Greg Kroah-Hartman
2021-03-08 20:25 ` irqchip-bot for Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YC4oGsBTyMJrGJ9C@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=michael@walle.cc \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).