From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF769C43331 for ; Thu, 18 Feb 2021 12:37:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF57464EB4 for ; Thu, 18 Feb 2021 12:37:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233010AbhBRMfA (ORCPT ); Thu, 18 Feb 2021 07:35:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:59310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230227AbhBRK4a (ORCPT ); Thu, 18 Feb 2021 05:56:30 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4A34864E4B; Thu, 18 Feb 2021 10:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613644969; bh=ZVEU0Q4v1c0QFBCQIPsDVziRocJEP0A7qMixZrKXSRE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rmUp03bp01fFVhuOtS4zYNrRo05P/MHjCURv84sjfVQ+9zWYsOMpbvWOYpHeuVbAi oQynA6AuV3SFXcUY5F4Q6SqAzxh1AhwfjM+QB4ZBCn9DfCPe/yY/rsk5GUwCkMcoE9 dRe+VOjSsRjh4L68f0pVpld/UnKtBpLxuy/wqx0g= Date: Thu, 18 Feb 2021 11:42:46 +0100 From: Greg Kroah-Hartman To: Badhri Jagan Sridharan Cc: Guenter Roeck , Heikki Krogerus , Kyle Tso , USB , LKML Subject: Re: [PATCH v1] usb: typec: tcpm: Wait for vbus discharge to VSAFE0V before toggling Message-ID: References: <20210218100243.32187-1-badhri@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 02:38:45AM -0800, Badhri Jagan Sridharan wrote: > Hi Greg, > > This patch is a bug fix for the following patch which was introduced in 5.11. > > commit f321a02caebdd0c56e167610cda2fa148cd96e8b > Author: Badhri Jagan Sridharan > Date: Wed Oct 28 23:31:35 2020 -0700 > > usb: typec: tcpm: Implement enabling Auto Discharge disconnect support > > TCPCI spec allows TCPC hardware to autonomously discharge the vbus > capacitance upon disconnect. The expectation is that the TCPM enables > AutoDischargeDisconnect while entering SNK/SRC_ATTACHED states. Hardware > then automously discharges vbus when the vbus falls below a certain > threshold i.e. VBUS_SINK_DISCONNECT_THRESHOLD. > > Apart from enabling the vbus discharge circuit, AutoDischargeDisconnect > is also used a flag to move TCPCI based TCPC implementations into > Attached.Snk/Attached.Src state as mentioned in > Figure 4-15. TCPC State Diagram before a Connection of the > USB Type-C Port Controller Interface Specification. > In such TCPC implementations, setting AutoDischargeDisconnect would > prevent TCPC into entering "Connection_Invalid" state as well. > > Signed-off-by: Badhri Jagan Sridharan > Reviewed-by: Heikki Krogerus > Link: https://lore.kernel.org/r/20201029063138.1429760-8-badhri@google.com > Signed-off-by: Greg Kroah-Hartman Great, then can you resend the patch and add a proper Fixes: tag, along with a cc: stable as well? thanks, greg k-h