Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie

From: "Krzysztof Wilczyński" <kw@linux.com>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: l.stach@pengutronix.de, helgaas@kernel.org, stefan@agner.ch,
	lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org,
	linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie
Date: Thu, 18 Feb 2021 18:34:05 +0100	[thread overview]
Message-ID: <YC6lDYG13DhIppmW@rocinante> (raw)
In-Reply-To: <YC5VmRTIylDHSFPt@rocinante>

[...]
> > Refer to commit 075af61c19cd ("PCI: imx6: Limit DBI register length"),
> > i.MX6QP PCIe has the similar issue.
> > Define the length of the DBI registers and limit config space to its
> > length for i.MX6QP PCIe too.
> 
> You could probably flip these two sentences around to make the commit
> message read slightly better, so what about this (a suggestion):
> 
> Define the length of the DBI registers and limit config space to its
> length. This makes sure that the kernel does not access registers beyond
> that point that otherwise would lead to an abort on a i.MX 6QuadPlus.
> 
> See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that
> resolves a similar issue on a i.MX 6Quad PCIe.
[...]

If you do decide to send another version, then also use "PCIe" in the
subject, rather than "pcie".  I forgot to mention this in the previous
message, apologies.

Krzysztof