From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Nicholas Fraser <nfraser@codeweavers.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
"Frank Ch. Eigler" <fche@redhat.com>,
Song Liu <songliubraving@fb.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kim Phillips <kim.phillips@amd.com>,
Tommi Rantala <tommi.t.rantala@nokia.com>,
Remi Bernon <rbernon@codeweavers.com>,
linux-kernel@vger.kernel.org,
Ulrich Czekalla <uczekalla@codeweavers.com>,
Huw Davies <huw@codeweavers.com>
Subject: Re: [PATCH 1/4] perf buildid-cache: Don't skip 16-byte build-ids
Date: Thu, 18 Feb 2021 16:42:02 -0300 [thread overview]
Message-ID: <YC7DCg2bHB2+vtSx@kernel.org> (raw)
In-Reply-To: <YC10WPYjps4Z0H8B@krava>
Em Wed, Feb 17, 2021 at 08:54:00PM +0100, Jiri Olsa escreveu:
> On Wed, Feb 10, 2021 at 02:17:25PM -0500, Nicholas Fraser wrote:
> > lsdir_bid_tail_filter() ignored any build-id that wasn't exactly 20
> > bytes. This worked only for SHA-1 build-ids. The build-id for a PE file
> > is always a 16-byte GUID and ELF files can also have MD5 or UUID
> > build-ids.
> >
> > This fix changes the filter to allow build-ids between 16 and 20 bytes.
> >
> > Signed-off-by: Nicholas Fraser <nfraser@codeweavers.com>
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
Thanks, applied.
- Arnaldo
prev parent reply other threads:[~2021-02-18 19:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 19:17 [PATCH 1/4] perf buildid-cache: Don't skip 16-byte build-ids Nicholas Fraser
2021-02-15 14:31 ` Jiri Olsa
2021-02-16 16:35 ` Nicholas Fraser
2021-02-17 18:19 ` Arnaldo Carvalho de Melo
2021-02-17 19:24 ` Jiri Olsa
2021-02-17 19:54 ` Jiri Olsa
2021-02-18 19:42 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC7DCg2bHB2+vtSx@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=fche@redhat.com \
--cc=huw@codeweavers.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nfraser@codeweavers.com \
--cc=peterz@infradead.org \
--cc=rbernon@codeweavers.com \
--cc=songliubraving@fb.com \
--cc=tommi.t.rantala@nokia.com \
--cc=uczekalla@codeweavers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).