From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19D97C433DB for ; Fri, 19 Feb 2021 08:14:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C3ACD64EB8 for ; Fri, 19 Feb 2021 08:14:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229849AbhBSIOe (ORCPT ); Fri, 19 Feb 2021 03:14:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:57398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229656AbhBSIOZ (ORCPT ); Fri, 19 Feb 2021 03:14:25 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id CA81464EBD; Fri, 19 Feb 2021 08:13:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613722424; bh=0vt+ZRs9Rwe2i5MnPG83TOwiw+V1EdFAt+vD6kMqqyM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XQwbj6iiqSgDhGhwXCc5VMOTiPUvm0+mqRkDxCGzbDTo863PmS0p9nImHFPVga7zD wmsRCAHosIIMfo1SwdTwEnnS5pyQjB0Qsj1q3lCiQoRZKCYVQJXU/I2ruE3oF1s+64 LahreQ+/xdD5q231wXDvJz3b31spLRXf542ru1cc= Date: Fri, 19 Feb 2021 09:13:41 +0100 From: Greg KH To: Prakash Dubey Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fwserial: Fix alignment of function parameters Message-ID: References: <20210218102851.GA20810@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210218102851.GA20810@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 03:58:51PM +0530, Prakash Dubey wrote: > This patch fixes the following checkpatch.pl check: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Prakash Dubey > --- > drivers/staging/fwserial/fwserial.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c > index c368082aae1a..a92741b8b6c6 100644 > --- a/drivers/staging/fwserial/fwserial.c > +++ b/drivers/staging/fwserial/fwserial.c > @@ -1318,8 +1318,8 @@ static int fwtty_break_ctl(struct tty_struct *tty, int state) > if (state == -1) { > set_bit(STOP_TX, &port->flags); > ret = wait_event_interruptible_timeout(port->wait_tx, > - !test_bit(IN_TX, &port->flags), > - 10); > + !test_bit(IN_TX, &port->flags), > + 10); Shouldn't you make this line up with the ( above? This indents it a bit further :( thanks, greg k-h