From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1203EC433DB for ; Tue, 9 Feb 2021 17:29:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB82764EBE for ; Tue, 9 Feb 2021 17:29:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233264AbhBIR3I (ORCPT ); Tue, 9 Feb 2021 12:29:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:56540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233226AbhBIR1q (ORCPT ); Tue, 9 Feb 2021 12:27:46 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 93D8364DF2; Tue, 9 Feb 2021 17:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612891626; bh=qTfLx1VSCrJdbq+U+ZBzpFEkk/dbITaWRG3yv1BA2As=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PQ9xt1UvfE61J48dZKtKdAegmfk104Vb3+pyS5nPqdOr1BG25ram7e63gl4CfimIz SZnDjXbC9AMnBobZ+hepHkiihIURHf1UCcfKBuja/bK7IkJCMPLcLXF+aKcUvb7zFC QOJ2vDBgi4/PtQcS9+V/WhwPE3K69SQbckmFIzAc= Date: Tue, 9 Feb 2021 18:27:03 +0100 From: Greg KH To: Mukul Mehar Cc: devel@driverdev.osuosl.org, christian.gromm@microchip.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Drivers: staging: most: sound: Fixed styling issue. Message-ID: References: <20210209130618.18508-1-mukulmehar02@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210209130618.18508-1-mukulmehar02@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 09, 2021 at 06:36:19PM +0530, Mukul Mehar wrote: > This patch fixes a warning, of the line ending with a '(', > generated by checkpatch.pl. > > Signed-off-by: Mukul Mehar > --- > drivers/staging/most/sound/sound.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound/sound.c > index 3a1a59058042..4dd1bf95d1ce 100644 > --- a/drivers/staging/most/sound/sound.c > +++ b/drivers/staging/most/sound/sound.c > @@ -228,12 +228,12 @@ static int playback_thread(void *data) > struct mbo *mbo = NULL; > bool period_elapsed = false; > > - wait_event_interruptible( > - channel->playback_waitq, > - kthread_should_stop() || > - (channel->is_stream_running && > - (mbo = most_get_mbo(channel->iface, channel->id, > - &comp)))); > + wait_event_interruptible(channel->playback_waitq, > + kthread_should_stop() || > + (channel->is_stream_running && > + (mbo = most_get_mbo(channel->iface, > + channel->id, > + &comp)))); This line is horrid, you can indent it further (line up the most_get_mbo() parameters at the least. Also you lost the extra indentation of the "(mbo " portion, can you make sure that is there too? thanks, greg k-h