From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDB7EC433E6 for ; Wed, 10 Feb 2021 23:43:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CFBC60230 for ; Wed, 10 Feb 2021 23:43:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234006AbhBJXnS (ORCPT ); Wed, 10 Feb 2021 18:43:18 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:41978 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233955AbhBJXnN (ORCPT ); Wed, 10 Feb 2021 18:43:13 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EEDE845E; Thu, 11 Feb 2021 00:42:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1613000551; bh=F8M0gSMAeLtKdCNlwOMgSLqVGq6ljgVV0EdOao2CbA4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aHEDF/gWuFQk613AydGAp8/l+kl3EA6POw91pmmG940EsWRyCxOFrP/IBw8KThqw7 cmm1Vn7RxICJmf/M04QJq8Q0Klzvl+Ku9eK9JXtz1RdNBQ74OPeYIsFRWAJK5cCBtI oAC2WUrq5YC4zfQG/8RXb0gMvFle3DYNbtCQMcB4= Date: Thu, 11 Feb 2021 01:42:07 +0200 From: Laurent Pinchart To: "Gustavo A. R. Silva" Cc: Mauro Carvalho Chehab , Ricardo Ribalda , Tomasz Figa , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2][next] media: uvcvideo: Remove duplicate assignments to pointer dma_dev Message-ID: References: <20210210210149.GA842694@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210210210149.GA842694@embeddedor> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gustavo, Thank you for the patch. On Wed, Feb 10, 2021 at 03:01:49PM -0600, Gustavo A. R. Silva wrote: > Remove redundant assignments to pointer dma_dev. > > Fixes: fdcd02a641e2 ("media: uvcvideo: Use dma_alloc_noncontiguos API") > Addresses-Coverity-ID: 1501703 ("Evaluation order violation") > Addresses-Coverity-ID: 1501692 ("Evaluation order violation") > Signed-off-by: Gustavo A. R. Silva Colin King has already submitted the same patch ("[PATCH][next][V2] media: uvcvideo: remove duplicated dma_dev assignments"). As they're identical, I can only decide to use the first patch that reached my mailbox. > --- > Changes in v2: > - Remove another redundant assignment in function > uvc_free_urb_buffers(). > > drivers/media/usb/uvc/uvc_video.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c > index dc81f9a86eca..6f2f308d86fe 100644 > --- a/drivers/media/usb/uvc/uvc_video.c > +++ b/drivers/media/usb/uvc/uvc_video.c > @@ -1105,7 +1105,7 @@ static inline struct device *stream_to_dmadev(struct uvc_streaming *stream) > > static void uvc_urb_dma_sync(struct uvc_urb *uvc_urb, bool for_device) > { > - struct device *dma_dev = dma_dev = stream_to_dmadev(uvc_urb->stream); > + struct device *dma_dev = stream_to_dmadev(uvc_urb->stream); > > if (for_device) { > dma_sync_sgtable_for_device(dma_dev, uvc_urb->sgt, > @@ -1586,7 +1586,7 @@ static void uvc_video_complete(struct urb *urb) > */ > static void uvc_free_urb_buffers(struct uvc_streaming *stream) > { > - struct device *dma_dev = dma_dev = stream_to_dmadev(stream); > + struct device *dma_dev = stream_to_dmadev(stream); > struct uvc_urb *uvc_urb; > > for_each_uvc_urb(uvc_urb, stream) { -- Regards, Laurent Pinchart