From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Timur Tabi <timur@kernel.org>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Vlastimil Babka <vbabka@suse.cz>,
Matthew Wilcox <willy@infradead.org>,
akpm@linux-foundation.org,
Linus Torvalds <torvalds@linux-foundation.org>,
roman.fietze@magna.com, Kees Cook <keescook@chromium.org>,
John Ogness <john.ogness@linutronix.de>,
akinobu.mita@gmail.com, glider@google.com,
Andrey Konovalov <andreyknvl@google.com>,
Marco Elver <elver@google.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Pavel Machek <pavel@ucw.cz>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 0/3][v3] add support for never printing hashed addresses
Date: Thu, 11 Feb 2021 12:44:57 +0200 [thread overview]
Message-ID: <YCUKqUc8GNjZLI16@smile.fi.intel.com> (raw)
In-Reply-To: <20210210213453.1504219-1-timur@kernel.org>
On Wed, Feb 10, 2021 at 03:34:50PM -0600, Timur Tabi wrote:
> [The list of email addresses on CC: is getting quite lengthy,
> so I hope I've included everyone.]
>
> Although hashing addresses printed via printk does make the
> kernel more secure, it interferes with debugging, especially
> with some functions like print_hex_dump() which always uses
> hashed addresses.
>
> To avoid having to choose between %p and %px, it's easier to
> add a kernel command line that treats all %p as %px. This
> encourages developers to use %p more without making debugging
> more difficult.
>
> Patches #1 and #2 upgrade the kselftest framework so that
> it can report on tests that were skipped outright. This
> is needed for the test_printf module which will now skip
> %p hashing tests if hashing is disabled.
>
> Patch #2 upgrades the printf library to check the command
> line. It also updates test_printf().
Side note to the future contributions.
> Full series:
>
> Acked-by: Marco Elver <elver@google.com>
That's what you usually add to each patch in the series individually.
You may use simple oneliner for this, i.e. `git filter-branch --msg-filter ...`
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-02-11 10:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 21:34 [PATCH 0/3][v3] add support for never printing hashed addresses Timur Tabi
2021-02-10 21:34 ` [PATCH 1/3] [v3] lib: use KSTM_MODULE_GLOBALS macro in kselftest drivers Timur Tabi
2021-02-10 21:34 ` [PATCH 2/3] [v3] kselftest: add support for skipped tests Timur Tabi
2021-02-12 11:07 ` Petr Mladek
2021-02-10 21:34 ` [PATCH 3/3] [v3] lib/vsprintf: debug_never_hash_pointers prints all addresses as unhashed Timur Tabi
2021-02-11 12:31 ` Pavel Machek
2021-02-11 17:08 ` Timur Tabi
2021-02-11 17:20 ` Matthew Wilcox
2021-02-12 10:01 ` Petr Mladek
2021-02-12 20:29 ` Timur Tabi
2021-02-11 17:23 ` Petr Mladek
2021-02-11 18:17 ` Timur Tabi
2021-02-11 17:53 ` Petr Mladek
2021-02-11 18:16 ` Timur Tabi
2021-02-11 10:44 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCUKqUc8GNjZLI16@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=john.ogness@linutronix.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pavel@ucw.cz \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=pmladek@suse.com \
--cc=roman.fietze@magna.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=timur@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).