linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Carstens <hca@linux.ibm.com>
To: Vlad Buslov <vladbu@nvidia.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Dmytro Linkin <dlinkin@nvidia.com>, Roi Dayan <roid@nvidia.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for Feb 11
Date: Fri, 12 Feb 2021 12:03:08 +0100	[thread overview]
Message-ID: <YCZgbOpD1xDw4PT8@osiris> (raw)
In-Reply-To: <ygnh8s7tsk4i.fsf@nvidia.com>

Hi Vlad,

> > Build fails on s390 using defconfig with:
> >
> > In file included from drivers/net/ethernet/mellanox/mlx5/core/en_tc.h:40,
> >                  from drivers/net/ethernet/mellanox/mlx5/core/en_main.c:45:
> > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.h:24:29: error: field 'match_level' has incomplete type
> >    24 |  enum mlx5_flow_match_level match_level;
> >       |                             ^~~~~~~~~~~
> > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.h:27:26: warning: 'struct mlx5e_encap_entry' declared inside parameter list will not be visible outside of this definition or declaration
> >    27 |  int (*calc_hlen)(struct mlx5e_encap_entry *e);
> >       |                          ^~~~~~~~~~~~~~~~~
> >
> > caused by this:
> > commit 0d9f96471493d5483d116c137693f03604332a04 (HEAD, refs/bisect/bad)
> > Author: Vlad Buslov <vladbu@nvidia.com>
> > Date:   Sun Jan 24 22:07:04 2021 +0200
> >
> >     net/mlx5e: Extract tc tunnel encap/decap code to dedicated file
> >     
> >     Following patches in series extend the extracted code with routing
> >     infrastructure. To improve code modularity created a dedicated
> >     tc_tun_encap.c source file and move encap/decap related code to the new
> >     file. Export code that is used by both regular TC code and encap/decap code
> >     into tc_priv.h (new header intended to be used only by TC module). Rename
> >     some exported functions by adding "mlx5e_" prefix to their names.
> >     
> >     Signed-off-by: Vlad Buslov <vladbu@nvidia.com>
> >     Signed-off-by: Dmytro Linkin <dlinkin@nvidia.com>
> >     Reviewed-by: Roi Dayan <roid@nvidia.com>
> >     Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
> >
> > Note: switching on NET_SWITCHDEV fixes the build error.
> 
> Hi Heiko,
> 
> This problem is supposed to be fixed by 36280f0797df ("net/mlx5e: Fix
> tc_tun.h to verify MLX5_ESWITCH config"). I'm trying to reproduce with
> config supplied by test robot in another thread (config: s390-defconfig)
> and current net-next builds fine for me. I've also verified that config
> option you mentioned is not set in that config:
> 
> $ grep NET_SWITCHDEV .config
> # CONFIG_NET_SWITCHDEV is not set
> 
> Can you help me reproduce?

The commit you mention is not part of linux-next 20210211 (I'm not
talking of net-next). So, probably will be fixed with today's
release. I just checked: net-next builds with s390 defconfig.

Thanks!

  reply	other threads:[~2021-02-12 11:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11 11:26 Stephen Rothwell
2021-02-11 18:18 ` linux-next: Tree for Feb 11 (drivers/gpu/drm/i915/display/intel_panel.o) Randy Dunlap
2021-02-11 20:30 ` linux-next: Tree for Feb 11 Heiko Carstens
2021-02-12  9:36   ` Vlad Buslov
2021-02-12 11:03     ` Heiko Carstens [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-02-11  7:53 Stephen Rothwell
2020-02-11  2:00 Stephen Rothwell
2019-02-11  7:39 Stephen Rothwell
2016-02-11  5:45 Stephen Rothwell
2015-02-11  6:44 Stephen Rothwell
2014-02-11  6:21 Stephen Rothwell
2013-02-11  7:47 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCZgbOpD1xDw4PT8@osiris \
    --to=hca@linux.ibm.com \
    --cc=dlinkin@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=roid@nvidia.com \
    --cc=saeedm@nvidia.com \
    --cc=sfr@canb.auug.org.au \
    --cc=vladbu@nvidia.com \
    --subject='Re: linux-next: Tree for Feb 11' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).