From: Andrew Lunn <andrew@lunn.ch>
To: Stefan Chulski <stefanc@marvell.com>
Cc: Marcin Wojtas <mw@semihalf.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>,
Yan Markman <ymarkman@marvell.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"rmk+kernel@armlinux.org.uk" <rmk+kernel@armlinux.org.uk>,
"atenart@kernel.org" <atenart@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"sebastian.hesselbarth@gmail.com"
<sebastian.hesselbarth@gmail.com>,
"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [PATCH v12 net-next 12/15] net: mvpp2: add BM protection underrun feature support
Date: Mon, 15 Feb 2021 01:38:38 +0100 [thread overview]
Message-ID: <YCnCjomjF0LDglAg@lunn.ch> (raw)
In-Reply-To: <CO6PR18MB3873E319FA08ADBC3B682828B0899@CO6PR18MB3873.namprd18.prod.outlook.com>
> > Does this even need to be configurable? What is the cost of turning it on?
> > How does having less pools affect the system? Does average latency go up?
> > When would i consider an underrun actually a good thing?
> >
> > Maybe it should just be hard coded on? Or we should try to detect when
> > underruns are happening a lot, and dynamically turn it on for a while?
> >
> The cost of this change is that the number of pools reduced from 16 to 8.
> The current driver uses only 4pools, but some future features like QoS can use over 4 pools.
So you are saying, there is currently no cost for turning it on. So it
seems like you should just turn it on, and forget the module
parameter. When QoS features are added which require more than 8 pools
you can then address the issue of if this should be configurable.
Andrew
next prev parent reply other threads:[~2021-02-15 0:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 9:48 [PATCH v12 net-next 00/15] net: mvpp2: Add TX Flow Control support stefanc
2021-02-10 9:48 ` [PATCH v12 net-next 01/15] doc: marvell: add CM3 address space and PPv2.3 description stefanc
2021-02-10 17:24 ` Rob Herring
2021-02-10 9:48 ` [PATCH v12 net-next 02/15] dts: marvell: add CM3 SRAM memory to cp11x ethernet device tree stefanc
2021-02-10 9:48 ` [PATCH v12 net-next 03/15] net: mvpp2: add CM3 SRAM memory map stefanc
2021-02-10 9:48 ` [PATCH v12 net-next 04/15] net: mvpp2: always compare hw-version vs MVPP21 stefanc
2021-02-10 9:48 ` [PATCH v12 net-next 05/15] net: mvpp2: add PPv23 version definition stefanc
2021-02-10 9:48 ` [PATCH v12 net-next 06/15] net: mvpp2: increase BM pool and RXQ size stefanc
2021-02-10 9:48 ` [PATCH v12 net-next 07/15] net: mvpp2: add FCA periodic timer configurations stefanc
2021-02-10 9:48 ` [PATCH v12 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold stefanc
2021-02-10 9:48 ` [PATCH v12 net-next 09/15] net: mvpp2: enable global flow control stefanc
2021-02-10 9:48 ` [PATCH v12 net-next 10/15] net: mvpp2: add RXQ flow control configurations stefanc
2021-02-10 9:48 ` [PATCH v12 net-next 11/15] net: mvpp2: add ethtool flow control configuration support stefanc
2021-02-10 9:48 ` [PATCH v12 net-next 12/15] net: mvpp2: add BM protection underrun feature support stefanc
2021-02-10 23:29 ` David Miller
2021-02-11 8:22 ` [EXT] " Stefan Chulski
2021-02-11 14:19 ` Andrew Lunn
2021-02-11 19:13 ` Marcin Wojtas
2021-02-12 13:52 ` Andrew Lunn
2021-02-14 9:20 ` Stefan Chulski
2021-02-15 0:38 ` Andrew Lunn [this message]
2021-02-10 9:48 ` [PATCH v12 net-next 13/15] net: mvpp2: add PPv23 RX FIFO flow control stefanc
2021-02-10 9:48 ` [PATCH v12 net-next 14/15] net: mvpp2: set 802.3x GoP Flow Control mode stefanc
2021-02-10 9:48 ` [PATCH v12 net-next 15/15] net: mvpp2: add TX FC firmware check stefanc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCnCjomjF0LDglAg@lunn.ch \
--to=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).