From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C33E4C433E0 for ; Mon, 15 Feb 2021 13:24:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9175C64E29 for ; Mon, 15 Feb 2021 13:24:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230365AbhBONXX (ORCPT ); Mon, 15 Feb 2021 08:23:23 -0500 Received: from mga09.intel.com ([134.134.136.24]:54806 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229738AbhBONWl (ORCPT ); Mon, 15 Feb 2021 08:22:41 -0500 IronPort-SDR: 5jBAlANxipkf5eOocuv2V7NkcF7OZIE/Vv3P+XveSSSUDn7wTLp2Nq/FBlFNXR7axhMEGuCrOa uwd4xrhq/xMA== X-IronPort-AV: E=McAfee;i="6000,8403,9895"; a="182809238" X-IronPort-AV: E=Sophos;i="5.81,180,1610438400"; d="scan'208";a="182809238" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 05:20:46 -0800 IronPort-SDR: ni4OXckW4L+aJIPdFOZ9pQkZww/w+Syf7XCWV9NFEfkw6YP2EviRHCjcNvYDlLHEuUnsMW7ERK jSGAVmIJd+WA== X-IronPort-AV: E=Sophos;i="5.81,180,1610438400"; d="scan'208";a="492734902" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 05:20:43 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lBdns-005CPw-In; Mon, 15 Feb 2021 15:20:40 +0200 Date: Mon, 15 Feb 2021 15:20:40 +0200 From: Andy Shevchenko To: Dejin Zheng Cc: jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, wsa@kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH i2c-next] i2c: designware: Consolidate pci_free_irq_vectors to a single place Message-ID: References: <20210214064529.481341-1-zhengdejin5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210214064529.481341-1-zhengdejin5@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 14, 2021 at 02:45:29PM +0800, Dejin Zheng wrote: > Consolidate pci_free_irq_vectors to a single place using "goto free_irq" > for simplify the code. One nit below, after addressing: Reviewed-by: Andy Shevchenko ... > +free_irq: It's quite confusing name. I would expect to see here (with current proposal) *free_irq() call, but no, I don't see a such. Please, change to something like err_pci_free_irq_vectors: or alternatively err_free_irq_vectors: however I think first one is disambiguous. > + pci_free_irq_vectors(pdev); > + return r; -- With Best Regards, Andy Shevchenko