From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
Petr Mladek <pmladek@suse.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
dri-devel@lists.freedesktop.org, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Joe Perches <joe@perches.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v7 3/3] drm: Switch to %p4cc format modifier
Date: Mon, 15 Feb 2021 19:36:14 +0200 [thread overview]
Message-ID: <YCqxDsCpjODcLhbp@smile.fi.intel.com> (raw)
In-Reply-To: <20210215172655.GL3@paasikivi.fi.intel.com>
On Mon, Feb 15, 2021 at 07:26:55PM +0200, Sakari Ailus wrote:
> On Mon, Feb 15, 2021 at 03:41:14PM +0200, Andy Shevchenko wrote:
> ...
> > > + seq_printf(m, "\t\tuapi: [FB:%d] ", fb ? fb->base.id : 0);
> > > + if (fb)
> > > + seq_printf(m, "%p4cc", &fb->format->format);
> > > + else
> > > + seq_puts(m, "n/a");
> >
> > > + seq_printf(m, ",0x%llx,%dx%d, visible=%s, src=" DRM_RECT_FP_FMT ", dst=" DRM_RECT_FMT ", rotation=%s\n",
> >
> > Why not to keep two seq_printf() calls?
> >
> > if (fb) {
> > seq_printf();
> > } else {
> > seq_printf();
> > }
> >
> > ?
>
> I could, but it'd repeat a lot of the same format string that is very
> complicated right now. Therefore I thought it's better to split.
It's fine, why not?
> Or do you mean seq_printf() vs. seq_puts()? checkpatch.pl (rightly) warns
> about it.
If it doesn't take run-time parameters, then definitely
if (fb)
seq_printf();
else
seq_puts();
> > > fb ? fb->modifier : 0,
> > > fb ? fb->width : 0, fb ? fb->height : 0,
> > > plane_visibility(plane_state),
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-15 17:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 11:40 [PATCH v7 0/3] Add %p4cc printk modifier for V4L2 and DRM fourcc codes Sakari Ailus
2021-02-15 11:40 ` [PATCH v7 1/3] lib/vsprintf: Add support for printing V4L2 and DRM fourccs Sakari Ailus
2021-02-15 13:31 ` Andy Shevchenko
2021-02-15 13:56 ` Sakari Ailus
2021-02-15 15:54 ` Andy Shevchenko
2021-02-15 16:51 ` Petr Mladek
2021-02-15 17:21 ` Sakari Ailus
2021-02-15 11:40 ` [PATCH v7 2/3] v4l: ioctl: Use %p4cc printk modifier to print FourCC codes Sakari Ailus
2021-02-15 13:34 ` Andy Shevchenko
2021-02-15 13:50 ` Sakari Ailus
2021-02-15 16:56 ` Petr Mladek
2021-02-15 17:05 ` Mauro Carvalho Chehab
2021-02-15 17:22 ` Sakari Ailus
2021-02-15 11:40 ` [PATCH v7 3/3] drm: Switch to %p4cc format modifier Sakari Ailus
2021-02-15 13:41 ` Andy Shevchenko
2021-02-15 13:48 ` Sakari Ailus
2021-02-15 17:26 ` Sakari Ailus
2021-02-15 17:36 ` Andy Shevchenko [this message]
2021-02-15 16:58 ` Petr Mladek
2021-02-16 8:37 ` Thomas Zimmermann
2021-02-16 9:01 ` Sakari Ailus
2021-02-16 9:08 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCqxDsCpjODcLhbp@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil@xs4all.nl \
--cc=jani.nikula@linux.intel.com \
--cc=joe@perches.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mchehab@kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).