From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Parshuram Thombare <pthombar@cadence.com>
Cc: robert.foss@linaro.org, robh+dt@kernel.org, airlied@linux.ie,
daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
a.hajda@samsung.com, narmstrong@baylibre.com, nikhil.nd@ti.com,
kishon@ti.com, sjakhade@cadence.com, mparab@cadence.com
Subject: Re: [PATCH v2 1/2] dt-bindings: drm/bridge: MHDP8546 bridge binding changes for HDCP
Date: Mon, 1 Mar 2021 17:41:30 +0200 [thread overview]
Message-ID: <YD0LKg3Jl5nauMqF@pendragon.ideasonboard.com> (raw)
In-Reply-To: <1614597746-4563-1-git-send-email-pthombar@cadence.com>
Hi Parshuram,
Thank you for the patch.
On Mon, Mar 01, 2021 at 12:22:26PM +0100, Parshuram Thombare wrote:
> Add binding changes for HDCP in the MHDP8546 DPI/DP bridge binding.
> This binding is not used in any upstreamed DTS yet, so changing
> index of property 'j721e-intg' should not affect anything.
>
> Signed-off-by: Parshuram Thombare <pthombar@cadence.com>
> ---
> .../display/bridge/cdns,mhdp8546.yaml | 29 ++++++++++++-------
> 1 file changed, 19 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> index 63427878715e..5fdadadaac16 100644
> --- a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml
> @@ -17,21 +17,24 @@ properties:
> - ti,j721e-mhdp8546
>
> reg:
> - minItems: 1
> - maxItems: 2
> + minItems: 2
> + maxItems: 3
> items:
> - description:
> Register block of mhdptx apb registers up to PHY mapped area (AUX_CONFIG_P).
> The AUX and PMA registers are not part of this range, they are instead
> included in the associated PHY.
> + - description:
> + Register block of mhdptx sapb registers.
> - description:
> Register block for DSS_EDP0_INTG_CFG_VP registers in case of TI J7 SoCs.
>
> reg-names:
> - minItems: 1
> - maxItems: 2
> + minItems: 2
> + maxItems: 3
> items:
> - const: mhdptx
> + - const: mhdptx-sapb
> - const: j721e-intg
>
> clocks:
> @@ -53,6 +56,11 @@ properties:
> power-domains:
> maxItems: 1
>
> + hdcp-config:
> + maxItems: 1
> + description:
> + HDCP version supported. Bit [0]:HDCP2.2 [1]:HDCP1.4.
> +
Is this a property of the hardware, that is, are there multiple versions
of this IP core covered by the same compatible string that support HDCP
1.4 only, DHCP 2.2 only or both ? Or is it a way to select what a given
system will offer ?
> interrupts:
> maxItems: 1
>
> @@ -98,15 +106,15 @@ allOf:
> then:
> properties:
> reg:
> - minItems: 2
> + minItems: 3
> reg-names:
> - minItems: 2
> + minItems: 3
> else:
> properties:
> reg:
> - maxItems: 1
> + maxItems: 2
> reg-names:
> - maxItems: 1
> + maxItems: 2
>
> required:
> - compatible
> @@ -129,8 +137,9 @@ examples:
>
> mhdp: dp-bridge@f0fb000000 {
> compatible = "cdns,mhdp8546";
> - reg = <0xf0 0xfb000000 0x0 0x1000000>;
> - reg-names = "mhdptx";
> + reg = <0xf0 0xfb000000 0x0 0x1000000>,
> + <0x0 0x4f48000 0x0 0x74>;
> + reg-names = "mhdptx", "mhdptx-sapb";
> clocks = <&mhdp_clock>;
> phys = <&dp_phy>;
> phy-names = "dpphy";
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-03-01 15:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 11:21 [PATCH v2 0/2] enable HDCP in Cadence MHDP bridge driver Parshuram Thombare
2021-03-01 11:22 ` [PATCH v2 1/2] dt-bindings: drm/bridge: MHDP8546 bridge binding changes for HDCP Parshuram Thombare
2021-03-01 15:41 ` Laurent Pinchart [this message]
2021-03-01 16:14 ` Parshuram Raju Thombare
2021-03-01 16:27 ` Laurent Pinchart
2021-03-02 12:53 ` Parshuram Raju Thombare
2021-03-08 20:42 ` Laurent Pinchart
2021-03-09 8:02 ` Parshuram Raju Thombare
2021-03-08 17:36 ` Rob Herring
2021-03-09 15:35 ` Parshuram Raju Thombare
2021-03-01 11:23 ` [PATCH v2 2/2] drm: bridge: cdns-mhdp8546: Enable HDCP Parshuram Thombare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD0LKg3Jl5nauMqF@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mparab@cadence.com \
--cc=narmstrong@baylibre.com \
--cc=nikhil.nd@ti.com \
--cc=pthombar@cadence.com \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sjakhade@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).