linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 00/11] KVM: VMX: Clean up Hyper-V PV TLB flush
Date: Tue, 2 Mar 2021 10:56:18 -0800	[thread overview]
Message-ID: <YD6KUoZGE2UASLa5@google.com> (raw)
In-Reply-To: <7ed340f1-f6f7-4682-65be-6bc02f25d612@redhat.com>

On Wed, Jan 27, 2021, Paolo Bonzini wrote:
> On 27/10/20 22:23, Sean Christopherson wrote:
> > Clean up KVM's PV TLB flushing when running with EPT on Hyper-V, i.e. as
> > a nested VMM.  No real goal in mind other than the sole patch in v1, which
> > is a minor change to avoid a future mixup when TDX also wants to define
> > .remote_flush_tlb.  Everything else is opportunistic clean up.
> > 
> > Patch 1 legitimately tested on VMX (no SVM), everything else effectively
> > build tested only.
> > 
> > v3:
> >    - Add a patch to pass the root_hpa instead of pgd to vmx_load_mmu_pgd()
> >      and retrieve the active PCID only when necessary.  [Vitaly]
> >    - Selectively collects reviews (skipped a few due to changes). [Vitaly]
> >    - Explicitly invalidate hv_tlb_eptp instead of leaving it valid when
> >      the mismatch tracker "knows" it's invalid. [Vitaly]
> >    - Change the last patch to use "hv_root_ept" instead of "hv_tlb_pgd"
> >      to better reflect what is actually being tracked.
> > 
> > v2: Rewrite everything.
> > Sean Christopherson (11):
> >    KVM: x86: Get active PCID only when writing a CR3 value
> >    KVM: VMX: Track common EPTP for Hyper-V's paravirt TLB flush
> >    KVM: VMX: Stash kvm_vmx in a local variable for Hyper-V paravirt TLB
> >      flush
> >    KVM: VMX: Fold Hyper-V EPTP checking into it's only caller
> >    KVM: VMX: Do Hyper-V TLB flush iff vCPU's EPTP hasn't been flushed
> >    KVM: VMX: Invalidate hv_tlb_eptp to denote an EPTP mismatch
> >    KVM: VMX: Don't invalidate hv_tlb_eptp if the new EPTP matches
> >    KVM: VMX: Explicitly check for hv_remote_flush_tlb when loading pgd
> >    KVM: VMX: Define Hyper-V paravirt TLB flush fields iff Hyper-V is
> >      enabled
> >    KVM: VMX: Skip additional Hyper-V TLB EPTP flushes if one fails
> >    KVM: VMX: Track root HPA instead of EPTP for paravirt Hyper-V TLB
> >      flush
> > 
> >   arch/x86/include/asm/kvm_host.h |   4 +-
> >   arch/x86/kvm/mmu.h              |   2 +-
> >   arch/x86/kvm/svm/svm.c          |   4 +-
> >   arch/x86/kvm/vmx/vmx.c          | 134 ++++++++++++++++++--------------
> >   arch/x86/kvm/vmx/vmx.h          |  19 ++---
> >   5 files changed, 87 insertions(+), 76 deletions(-)
> > 
> 
> Queued, thanks.

Looks like this got shadow-banned, I'll send v4.

      reply	other threads:[~2021-03-02 22:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 21:23 [PATCH v3 00/11] KVM: VMX: Clean up Hyper-V PV TLB flush Sean Christopherson
2020-10-27 21:23 ` [PATCH v3 01/11] KVM: x86: Get active PCID only when writing a CR3 value Sean Christopherson
2020-11-12 10:11   ` Vitaly Kuznetsov
2021-01-27 17:30   ` Paolo Bonzini
2020-10-27 21:23 ` [PATCH v3 02/11] KVM: VMX: Track common EPTP for Hyper-V's paravirt TLB flush Sean Christopherson
2020-11-12 10:27   ` Vitaly Kuznetsov
2020-10-27 21:23 ` [PATCH v3 03/11] KVM: VMX: Stash kvm_vmx in a local variable for Hyper-V " Sean Christopherson
2020-10-27 21:23 ` [PATCH v3 04/11] KVM: VMX: Fold Hyper-V EPTP checking into it's only caller Sean Christopherson
2020-11-12 10:41   ` Vitaly Kuznetsov
2020-10-27 21:23 ` [PATCH v3 05/11] KVM: VMX: Do Hyper-V TLB flush iff vCPU's EPTP hasn't been flushed Sean Christopherson
2020-11-12 10:47   ` Vitaly Kuznetsov
2020-10-27 21:23 ` [PATCH v3 06/11] KVM: VMX: Invalidate hv_tlb_eptp to denote an EPTP mismatch Sean Christopherson
2020-11-12 10:50   ` Vitaly Kuznetsov
2020-10-27 21:23 ` [PATCH v3 07/11] KVM: VMX: Don't invalidate hv_tlb_eptp if the new EPTP matches Sean Christopherson
2020-10-27 21:23 ` [PATCH v3 08/11] KVM: VMX: Explicitly check for hv_remote_flush_tlb when loading pgd Sean Christopherson
2020-10-27 21:23 ` [PATCH v3 09/11] KVM: VMX: Define Hyper-V paravirt TLB flush fields iff Hyper-V is enabled Sean Christopherson
2020-11-12 10:52   ` Vitaly Kuznetsov
2020-10-27 21:23 ` [PATCH v3 10/11] KVM: VMX: Skip additional Hyper-V TLB EPTP flushes if one fails Sean Christopherson
2020-11-12 10:59   ` Vitaly Kuznetsov
2020-10-27 21:23 ` [PATCH v3 11/11] KVM: VMX: Track root HPA instead of EPTP for paravirt Hyper-V TLB flush Sean Christopherson
2020-11-12 11:02   ` Vitaly Kuznetsov
2021-01-27 18:10 ` [PATCH v3 00/11] KVM: VMX: Clean up Hyper-V PV " Paolo Bonzini
2021-03-02 18:56   ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YD6KUoZGE2UASLa5@google.com \
    --to=seanjc@google.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).