From: Michal Hocko <mhocko@suse.com>
To: Roman Gushchin <guro@fb.com>
Cc: Muchun Song <songmuchun@bytedance.com>,
hannes@cmpxchg.org, akpm@linux-foundation.org,
shakeelb@google.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: memcontrol: fix kernel stack account
Date: Tue, 2 Mar 2021 20:33:20 +0100 [thread overview]
Message-ID: <YD6TAMSafzrnl+Qj@dhcp22.suse.cz> (raw)
In-Reply-To: <YD6I+DLH0SLnSgo8@carbon.dhcp.thefacebook.com>
On Tue 02-03-21 10:50:32, Roman Gushchin wrote:
> On Tue, Mar 02, 2021 at 03:37:33PM +0800, Muchun Song wrote:
> > The alloc_thread_stack_node() cannot guarantee that allocated stack pages
> > are in the same node when CONFIG_VMAP_STACK. Because we do not specify
> > __GFP_THISNODE to __vmalloc_node_range(). Fix it by caling
> > mod_lruvec_page_state() for each page one by one.
>
> Hm, I actually wonder if it makes any sense to split the stack over multiple
> nodes? Maybe we should fix this instead?
While this is not really ideal I am not really sure it is an actual
problem worth complicating the code. I am pretty sure this would grow
into more tricky problem quite quickly (e.g. proper memory policy
handling).
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-03-02 22:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 7:37 [PATCH] mm: memcontrol: fix kernel stack account Muchun Song
2021-03-02 8:44 ` Michal Hocko
2021-03-02 9:23 ` [External] " Muchun Song
2021-03-02 9:34 ` Michal Hocko
2021-03-02 9:49 ` Muchun Song
2021-03-02 14:04 ` Shakeel Butt
2021-03-02 14:02 ` Shakeel Butt
2021-03-02 14:18 ` Michal Hocko
2021-03-02 18:50 ` Roman Gushchin
2021-03-02 19:33 ` Michal Hocko [this message]
2021-03-02 20:37 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD6TAMSafzrnl+Qj@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).