From: Greg KH <gregkh@linuxfoundation.org>
To: Xiaoming Ni <nixiaoming@huawei.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
sashal@kernel.org, tglx@linutronix.de, wangle6@huawei.com,
zhengyejian1@huawei.com
Subject: Re: [PATCH stable-rc queue/4.9 1/1] futex: Provide distinct return value when owner is exiting
Date: Mon, 22 Feb 2021 13:09:24 +0100 [thread overview]
Message-ID: <YDOe9GNivoHQphQc@kroah.com> (raw)
In-Reply-To: <3bc570f6-f8af-b0a2-4d62-13ed4adc1f33@huawei.com>
On Mon, Feb 22, 2021 at 06:54:06PM +0800, Xiaoming Ni wrote:
> On 2021/2/22 18:16, Greg KH wrote:
> > On Mon, Feb 22, 2021 at 03:03:28PM +0800, Xiaoming Ni wrote:
> > > From: Thomas Gleixner<tglx@linutronix.de>
> > >
> > > commit ac31c7ff8624409ba3c4901df9237a616c187a5d upstream.
> > This commit is already in the 4.9 tree. If the backport was incorrect,
> > say that here, and describe what went wrong and why this commit fixes
> > it.
> >
> > Also state what commit this fixes as well, otherwise this changelog just
> > looks like it is being applied again to the tree, which doesn't make
> > much sense.
> >
> > thanks,
> >
> > greg k-h
> > .
>
> I wrote a cover for it. but forgot to adjust the title of the cover:
>
> https://lore.kernel.org/lkml/20210222070328.102384-1-nixiaoming@huawei.com/
>
>
> I found a dead code in the queue/4.9 branch of the stable-rc repository.
>
> 2021-02-03:
> commit c27f392040e2f6 ("futex: Provide distinct return value when
> owner is exiting")
> The function handle_exit_race does not exist. Therefore, the
> change in handle_exit_race() is ignored in the patch round.
>
> 2021-02-22:
> commit e55cb811e612 ("futex: Cure exit race")
> Define the handle_exit_race() function,
> but no branch in the function returns EBUSY.
> As a result, dead code occurs in the attach_to_pi_owner():
>
> int ret = handle_exit_race(uaddr, uval, p);
> ...
> if (ret == -EBUSY)
> *exiting = p; /* dead code */
>
> To fix the dead code, modify the commit e55cb811e612 ("futex: Cure exit
> race"),
> or install a patch to incorporate the changes in handle_exit_race().
>
> I am unfamiliar with the processing of the stable-rc queue branch,
> and I cannot find the patch mail of the current branch in
> https://lore.kernel.org/lkml/?q=%22futex%3A+Cure+exit+race%22
> Therefore, I re-integrated commit ac31c7ff8624 ("futex: Provide distinct
> return value when owner is exiting").
> And wrote a cover (but forgot to adjust the title of the cover):
>
> https://lore.kernel.org/lkml/20210222070328.102384-1-nixiaoming@huawei.com/
So this is a "fixup" patch, right?
Please clearly label it as such in your patch description and resend
this as what is here I can not apply at all.
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-22 12:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 7:03 [PATCH stable-rc queue/4.9 0/1] repatch Xiaoming Ni
2021-02-22 7:03 ` [PATCH stable-rc queue/4.9 1/1] futex: Provide distinct return value when owner is exiting Xiaoming Ni
2021-02-22 10:16 ` Greg KH
2021-02-22 10:54 ` Xiaoming Ni
2021-02-22 12:09 ` Greg KH [this message]
2021-02-22 14:11 ` Xiaoming Ni
2021-02-23 13:00 ` Greg KH
2021-02-24 1:41 ` Xiaoming Ni
2021-02-24 7:47 ` Greg KH
2021-02-24 12:40 ` Xiaoming Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDOe9GNivoHQphQc@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=wangle6@huawei.com \
--cc=zhengyejian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).