From: Alex Riesen <alexander.riesen@cetitec.com>
To: Lyude Paul <lyude@redhat.com>
Cc: nouveau@lists.freedesktop.org,
Martin Peres <martin.peres@free.fr>,
Jeremy Cline <jcline@redhat.com>, Simon Ser <contact@emersion.fr>,
Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Dave Airlie <airlied@redhat.com>,
Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>,
Takashi Iwai <tiwai@suse.de>, James Jones <jajones@nvidia.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace
Date: Tue, 23 Feb 2021 15:15:21 +0100 [thread overview]
Message-ID: <YDUN+Re/alMVL0Zn@pflmari> (raw)
In-Reply-To: <20210119015415.2511028-2-lyude@redhat.com>
Lyude Paul, Tue, Jan 19, 2021 02:54:13 +0100:
> diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> index c6367035970e..5f4f09a601d4 100644
> --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
> +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
> @@ -2663,6 +2663,14 @@ nv50_display_create(struct drm_device *dev)
> else
> nouveau_display(dev)->format_modifiers = disp50xx_modifiers;
>
> + if (disp->disp->object.oclass >= GK104_DISP) {
> + dev->mode_config.cursor_width = 256;
> + dev->mode_config.cursor_height = 256;
> + } else {
> + dev->mode_config.cursor_width = 64;
> + dev->mode_config.cursor_height = 64;
> + }
> +
> /* create crtc objects to represent the hw heads */
> if (disp->disp->object.oclass >= GV100_DISP)
> crtcs = nvif_rd32(&device->object, 0x610060) & 0xff;
This change broke X cursor in my setup, and reverting the commit restores it.
Dell Precision M4800, issue ~2014 with GK106GLM [Quadro K2100M] (rev a1).
libdrm 2.4.91-1 (Debian 10.8 stable).
There are no errors or warnings in Xorg logs nor in the kernel log.
Regards,
Alex
next prev parent reply other threads:[~2021-02-23 14:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 1:54 [PATCH 1/3] drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes Lyude Paul
2021-01-19 1:54 ` [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace Lyude Paul
2021-01-19 10:22 ` Simon Ser
2021-02-23 14:15 ` Alex Riesen [this message]
2021-02-23 14:56 ` Ilia Mirkin
2021-02-23 15:36 ` Alex Riesen
2021-02-23 15:46 ` Ilia Mirkin
2021-02-23 15:51 ` Alex Riesen
2021-02-23 16:22 ` Alex Riesen
2021-02-23 18:13 ` Ilia Mirkin
2021-02-24 9:08 ` Alex Riesen
2021-01-19 1:54 ` [PATCH 3/3] drm/nouveau/kms/nve4-nv138: Fix > 64x64 cursors Lyude Paul
2021-01-19 10:18 ` [PATCH 1/3] drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes Simon Ser
2021-01-19 15:50 ` Ville Syrjälä
2021-01-19 15:52 ` James Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDUN+Re/alMVL0Zn@pflmari \
--to=alexander.riesen@cetitec.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=bskeggs@redhat.com \
--cc=contact@emersion.fr \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jajones@nvidia.com \
--cc=jcline@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=martin.peres@free.fr \
--cc=nouveau@lists.freedesktop.org \
--cc=pankaj.laxminarayan.bharadiya@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).