From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEF93C43381 for ; Fri, 26 Feb 2021 22:22:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FA8B64DBD for ; Fri, 26 Feb 2021 22:22:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229698AbhBZWWA (ORCPT ); Fri, 26 Feb 2021 17:22:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:55136 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230083AbhBZWVy (ORCPT ); Fri, 26 Feb 2021 17:21:54 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5532264EC4; Fri, 26 Feb 2021 22:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614378068; bh=M/OuyHOjC9MzHNaxSVLYAi5rdaxbhm5uZgeZBX2G6Ro=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d3t3FNtryc1UhKe1+Jg4VDk5bK0a4sz/j8ZV0Dwr1mngV5ykWhd3zHyxSVBiFcnlb 25z0XmZMv6MzhyIB4KqyEK02gz9gsn/TW5g+RYE6lJYcDHEbShLDrRW82+2t3YgepL Mgf9okJ40C2y6SsVqPIF/cBsgR8zaXaCiW757EEibC8nxSe7QumqXLRExNNCbIRoZf Nhn1s8EoJMR2E3NneNVsVlsE879Y0hG5HcOMPxNYvMXXlHKvsACmcxa284SVATJmAv stZpCmigY4bwXpXroYD/LQq5M7KXG9THiyFiSsUokO/t19mImZpaQ+SzgKASca/NgC /GjP2gg7ZbeVw== Date: Fri, 26 Feb 2021 14:21:06 -0800 From: Eric Biggers To: Sarthak Kukreti Cc: Theodore Ts'o , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Gwendal Grignou Subject: Re: [PATCH] ext4: Add xattr commands to compat ioctl handler Message-ID: References: <20210226221441.70071-1-sarthakkukreti@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210226221441.70071-1-sarthakkukreti@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2021 at 02:14:41PM -0800, Sarthak Kukreti wrote: > This allows 32-bit userspace utils to use FS_IOC_FSGETXATTR and > FS_IOC_FSSETXATTR on a 64-bit kernel. > > Signed-off-by: Sarthak Kukreti > --- > fs/ext4/ioctl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c > index f0381876a7e5b..055c26296ab46 100644 > --- a/fs/ext4/ioctl.c > +++ b/fs/ext4/ioctl.c > @@ -1371,6 +1371,8 @@ long ext4_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > return -EFAULT; > return ext4_ioctl_group_add(file, &input); > } > + case EXT4_IOC_FSGETXATTR: > + case EXT4_IOC_FSSETXATTR: > case EXT4_IOC_MOVE_EXT: > case EXT4_IOC_RESIZE_FS: > case FITRIM: These were already added to the list by commit a54d8d34d235 ("ext4: Add EXT4_IOC_FSGETXATTR/EXT4_IOC_FSSETXATTR to compat_ioctl"). - Eric