From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 838B8C433DB for ; Fri, 26 Feb 2021 22:36:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43D4F64EDC for ; Fri, 26 Feb 2021 22:36:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230022AbhBZWfk (ORCPT ); Fri, 26 Feb 2021 17:35:40 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:60924 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229795AbhBZWfe (ORCPT ); Fri, 26 Feb 2021 17:35:34 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lFlh1-008fcg-S9; Fri, 26 Feb 2021 23:34:39 +0100 Date: Fri, 26 Feb 2021 23:34:39 +0100 From: Andrew Lunn To: Don Bollinger Cc: arndb@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, brandon_chuang@edge-core.com, wally_wang@accton.com, aken_liu@edge-core.com, gulv@microsoft.com, jolevequ@microsoft.com, xinxliu@microsoft.com, netdev Subject: Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS Message-ID: References: <20210215193821.3345-1-don@thebollingers.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210215193821.3345-1-don@thebollingers.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 15, 2021 at 11:38:21AM -0800, Don Bollinger wrote: > optoe is an i2c based driver that supports read/write access to all > the pages (tables) of MSA standard SFP and similar devices (conforming > to the SFF-8472 spec), MSA standard QSFP and similar devices (conforming > to the SFF-8636 spec) and CMIS and similar devices (conforming to the > Common Management Interface Specfication). Hi Don Please make sure you Cc: netdev. This is networking stuff. And we have seen this code before, and the netdev Maintainers have argued against it before. > These devices provide identification, operational status and control > registers via an EEPROM model. These devices support one or 3 fixed pages > (128 bytes) of data, and one page that is selected via a page register on > the first fixed page. Thus the driver's main task is to map these pages > onto a simple linear address space for user space management applications. > See the driver code for a detailed layout. I assume you have seen the work NVIDIA submitted last week? This idea of linear pages is really restrictive and we are moving away from it. > The EEPROM data is accessible to user space and kernel consumers via the > nvmem interface. ethtool -m ? In the past, this code has been NACKed because it does not integrate into the networking stack. Is this attempt any different? Thanks Andrew