From: Rikard Falkeborn <rikard.falkeborn@gmail.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm/ppi: Constify static struct attribute_group
Date: Fri, 26 Feb 2021 22:56:12 +0100 [thread overview]
Message-ID: <YDlufJLcYN2bzNYV@rikard> (raw)
In-Reply-To: <YBynopNwhIhGBXv/@kernel.org>
On Fri, Feb 05, 2021 at 04:04:18AM +0200, Jarkko Sakkinen wrote:
> On Thu, Feb 04, 2021 at 10:54:27PM +0100, Rikard Falkeborn wrote:
> > The only usage of ppi_attr_grp is to put its address in an array of
> > pointers to const struct attribute_group. Make it const to allow the
> > compiler to put it in read-only memory.
> >
> > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
>
> Thanks.
>
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
>
> /Jarkko
>
Hi Jarkko,
I saw this was merged as commit
90cba8d20f8b09d62a25f9864cb8e67722d76c3a, but in the commit, there was an
additional change where a call to dump_stack() was added in
drivers/char/tpm/tpm-chip.c, was this intentional?
/Rikard
next prev parent reply other threads:[~2021-02-26 21:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 21:54 [PATCH] tpm/ppi: Constify static struct attribute_group Rikard Falkeborn
2021-02-05 2:04 ` Jarkko Sakkinen
2021-02-26 21:56 ` Rikard Falkeborn [this message]
2021-03-01 9:44 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDlufJLcYN2bzNYV@rikard \
--to=rikard.falkeborn@gmail.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).