From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AE27C433E6 for ; Mon, 1 Mar 2021 08:29:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C14B064DD3 for ; Mon, 1 Mar 2021 08:29:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233006AbhCAI3O (ORCPT ); Mon, 1 Mar 2021 03:29:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232898AbhCAI3B (ORCPT ); Mon, 1 Mar 2021 03:29:01 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD7BFC06174A; Mon, 1 Mar 2021 00:28:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SLHlTyr7J4bDHB68FVUYkSlUgSwJhgwwD2i9uVB39uY=; b=uVn9nYvH4/M/8OLvG8WZEVQfCq hBlKT6zXgY5YuhHzZxPgXGbisSXRCSaQWTTJN+dcVKLbhdt2dcascK+Es+bZuplCOAR6XYv3/HM4G nzdBWK57VLtTZ+BT3ZNLFNghOxviSosPsXMZrN6Zkj2ZQOnlxZWNtgoCdAP2Yn7PlE+CL8f3co4Id cd/6wC5Dujkq0m1aDBCVt+KVIBO9eBfGw3i9sXXm4sHlCgqGgbKsshfn+O81aAERgTMuJXcRfbeKF A+ZMau+w9bTvecM2jrIkxlxUL7lPBQCC54Shq83LaiagCZyPGgSUXxATnX0FHVKF8r18ZJiaFhOgQ 15iTFYrg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1lGduU-0006I4-HY; Mon, 01 Mar 2021 08:28:10 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id A0F6F301959; Mon, 1 Mar 2021 09:28:06 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8785025F2CD01; Mon, 1 Mar 2021 09:28:06 +0100 (CET) Date: Mon, 1 Mar 2021 09:28:06 +0100 From: Peter Zijlstra To: Shuah Khan Cc: mingo@redhat.com, will@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] lockdep: add lockdep_assert_not_held() Message-ID: References: <0ee409b7-b0d5-43c2-c247-b0482c392dea@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ee409b7-b0d5-43c2-c247-b0482c392dea@linuxfoundation.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2021 at 02:16:12PM -0700, Shuah Khan wrote: > On 2/26/21 2:07 PM, Peter Zijlstra wrote: > > On Fri, Feb 26, 2021 at 10:52:13AM -0700, Shuah Khan wrote: > > > + /* avoid false negative lockdep_assert_not_held() > > > + * and lockdep_assert_held() > > > + */ > > > > That's a coding style fail. > > > > Checkpatch didn't complain. Documentation/CodingStyle (or whatever unreadable rst crap it is today :-( ) and: https://lkml.kernel.org/lkml/CA+55aFyQYJerovMsSoSKS7PessZBr4vNp-3QUUwhqk4A4_jcbg@mail.gmail.com/ > What's your preference? Does the following work for you? > > /* > * avoid false negative lockdep_assert_not_held() > * and lockdep_assert_held() > */ Yep (ideally even with a Capital and full stop).