From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5C3AC43333 for ; Sun, 14 Mar 2021 02:20:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3E6C64ED0 for ; Sun, 14 Mar 2021 02:20:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233723AbhCNCQX (ORCPT ); Sat, 13 Mar 2021 21:16:23 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:45190 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231597AbhCNCPv (ORCPT ); Sat, 13 Mar 2021 21:15:51 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0320E55C; Sun, 14 Mar 2021 03:15:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1615688150; bh=DKsxYktuuGnusRXJGBQqTLHN0r6C6x8dBcI2xv+gbos=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pHZm8riY74l8W/JQpcFEYe4VWPBYb0NL+62WF/W5j5QFq89rRy2pRwspPS8FAKb4J IQIq1kOlo4eQUT43Px638X5Qa0Jdm+dh52yD7ZS3KFuhyJgn/di4uG+rlJvdAQkdYs DvJ/a2dxMDfmW9eIb3nDkaXc2UfSoII0crFFJNjo= Date: Sun, 14 Mar 2021 04:15:14 +0200 From: Laurent Pinchart To: angkery Cc: tomba@kernel.org, airlied@linux.ie, daniel@ffwll.ch, sebastian.reichel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Junlin Yang Subject: Re: [PATCH] drm/omap: dsi: fix unsigned expression compared with zero Message-ID: References: <20210312071445.1721-1-angkery@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210312071445.1721-1-angkery@163.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Junlin, Thank you for the patch. On Fri, Mar 12, 2021 at 03:14:45PM +0800, angkery wrote: > From: Junlin Yang > > r is "u32" always >= 0,mipi_dsi_create_packet may return little than zero. > so r < 0 condition is never accessible. > > Fixes coccicheck warnings: > ./drivers/gpu/drm/omapdrm/dss/dsi.c:2155:5-6: > WARNING: Unsigned expression compared with zero: r < 0 > > Signed-off-by: Junlin Yang Reviewed-by: Laurent Pinchart Tomi, will you take this in your tree ? > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index 8e11612..b31d750 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -2149,11 +2149,12 @@ static int dsi_vc_send_short(struct dsi_data *dsi, int vc, > const struct mipi_dsi_msg *msg) > { > struct mipi_dsi_packet pkt; > + int ret; > u32 r; > > - r = mipi_dsi_create_packet(&pkt, msg); > - if (r < 0) > - return r; > + ret = mipi_dsi_create_packet(&pkt, msg); > + if (ret < 0) > + return ret; > > WARN_ON(!dsi_bus_is_locked(dsi)); > -- Regards, Laurent Pinchart